Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 62532 config binding #66267

Closed
wants to merge 5 commits into from

Conversation

wcsanders1
Copy link
Contributor

This changes adds a test asserting that config file with a nested name and property with a value of empty string can properly bind to a model. closes #62532

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 6, 2022
@ghost
Copy link

ghost commented Mar 6, 2022

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

This changes adds a test asserting that config file with a nested name and property with a value of empty string can properly bind to a model. closes #62532

Author: wcsanders1
Assignees: -
Labels:

area-Extensions-Configuration, community-contribution

Milestone: -

@maryamariyan
Copy link
Member

@wcsanders1 issue #62532 that you are linking is a bug but your PR here is just making a test change. Did you mean to add more changes to this PR?

@maryamariyan maryamariyan added the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 15, 2022
@wcsanders1
Copy link
Contributor Author

@maryamariyan My intent with the test was to show that the bug is not reproduceable.

@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 15, 2022
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34582", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you intend to add this ActiveIssue line here?

@maryamariyan
Copy link
Member

Thanks for the explanation @wcsanders1 closing this PR. For more details refer to more updates in the issue page

@wcsanders1 wcsanders1 deleted the issue-62532_config_binding branch March 18, 2022 10:23
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IConfiguration binding behave unexpectedly when binding empty strings from nested configurations
2 participants