Change version to 1.5.13

dotnet · Nov 8, 2017 · d9e07e0 · d9e07e0
1 parent 9747ac6
commit d9e07e0
Show file tree

Hide file tree

Showing 20 changed files with 92 additions and 20 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,3 +1,17 @@
+### 1.5.13 (2017-11-09)
+
+#### Analyzers
+
+* Add analyzer RemoveRedundantAssignment (RCS1212).
+
+#### Refactorings
+
+* Add refactoring ReplaceCommentWithDocumentationComment (RR0192).
+
+#### Code Fixes
+
+* Add code fixes for CS0216, CS0659, CS0660, CS0661 and CS1526.
+
 ### 1.5.12 (2017-10-19)
 
 #### Analyzers

diff --git a/docs/analyzers/RCS1068.md b/docs/analyzers/RCS1068.md
@@ -1,10 +1,10 @@
-# RCS1068: Simplify logical not expression
+# RCS1068: Simplify logical negation
 
 Property | Value
 --- | --- 
 Id | RCS1068
 Category | Simplification
-Default Severity | Warning
+Default Severity | Info
 Enabled by Default | yes
 Supports Fade-Out | no
 Supports Fade-Out Analyzer | no
@@ -14,14 +14,14 @@ Supports Fade-Out Analyzer | no
 ### SuppressMessageAttribute
 
 ```csharp
-[assembly: SuppressMessage("Simplification", "RCS1068:Simplify logical not expression.", Justification = "<Pending>")]
+[assembly: SuppressMessage("Simplification", "RCS1068:Simplify logical negation.", Justification = "<Pending>")]
 ```
 
 ### \#pragma
 
 ```csharp
-#pragma warning disable RCS1068 // Simplify logical not expression.
-#pragma warning restore RCS1068 // Simplify logical not expression.
+#pragma warning disable RCS1068 // Simplify logical negation.
+#pragma warning restore RCS1068 // Simplify logical negation.
 ```
 
 ### Ruleset

diff --git a/docs/analyzers/RCS1212.md b/docs/analyzers/RCS1212.md
@@ -0,0 +1,29 @@
+# RCS1212: Remove redundant assignment
+
+Property | Value
+--- | --- 
+Id | RCS1212
+Category | Redundancy
+Default Severity | Info
+Enabled by Default | yes
+Supports Fade-Out | no
+Supports Fade-Out Analyzer | no
+
+## How to Suppress
+
+### SuppressMessageAttribute
+
+```csharp
+[assembly: SuppressMessage("Redundancy", "RCS1212:Remove redundant assignment.", Justification = "<Pending>")]
+```
+
+### \#pragma
+
+```csharp
+#pragma warning disable RCS1212 // Remove redundant assignment.
+#pragma warning restore RCS1212 // Remove redundant assignment.
+```
+
+### Ruleset
+
+* [How to configure rule set](../HowToConfigureAnalyzers.md)
diff --git a/docs/refactorings/RR0192.md b/docs/refactorings/RR0192.md
@@ -0,0 +1,14 @@
+## Replace comment with documentation comment
+
+Property | Value
+--- | --- 
+Id | RR0192
+Title | Replace comment with documentation comment
+Syntax | single\-line comment
+Enabled by Default | yes
+
+### Usage
+
+![Replace comment with documentation comment](../../images/refactorings/ReplaceCommentWithDocumentationComment.png)
+
+[full list of refactorings](Refactorings.md)
diff --git a/source/Analyzers/AnalyzersByCategory.md b/source/Analyzers/AnalyzersByCategory.md
@@ -99,6 +99,7 @@ Redundancy|[Remove enum default underlying type](../../docs/analyzers/RCS1042.md
 Redundancy|[Remove file with no code](../../docs/analyzers/RCS1093.md)|RCS1093|x
 Redundancy|[Remove 'partial' modifier from type with a single part](../../docs/analyzers/RCS1043.md)|RCS1043|x
 Redundancy|[Remove redundant 'as' operator](../../docs/analyzers/RCS1145.md)|RCS1145|x
+Redundancy|[Remove redundant assignment](../../docs/analyzers/RCS1212.md)|RCS1212|x
 Redundancy|[Remove redundant async/await](../../docs/analyzers/RCS1174.md)|RCS1174|x
 Redundancy|[Remove redundant auto\-property initialization](../../docs/analyzers/RCS1188.md)|RCS1188|x
 Redundancy|[Remove redundant base constructor call](../../docs/analyzers/RCS1071.md)|RCS1071|x
@@ -144,7 +145,7 @@ Simplification|[Simplify conditional expression](../../docs/analyzers/RCS1104.md
 Simplification|[Simplify lambda expression](../../docs/analyzers/RCS1021.md)|RCS1021|x
 Simplification|[Simplify lazily initialized property](../../docs/analyzers/RCS1171.md)|RCS1171|x
 Simplification|[Simplify LINQ method chain](../../docs/analyzers/RCS1077.md)|RCS1077|x
-Simplification|[Simplify logical not expression](../../docs/analyzers/RCS1068.md)|RCS1068|x
+Simplification|[Simplify logical negation](../../docs/analyzers/RCS1068.md)|RCS1068|x
 Simplification|[Simplify nested using statement](../../docs/analyzers/RCS1005.md)|RCS1005|x
 Simplification|[Simplify Nullable\<T\> to T?](../../docs/analyzers/RCS1020.md)|RCS1020|x
 Simplification|[Use \-\-/\+\+ operator instead of assignment](../../docs/analyzers/RCS1089.md)|RCS1089|x

diff --git a/source/Analyzers/Properties/AssemblyInfo.cs b/source/Analyzers/Properties/AssemblyInfo.cs
@@ -28,6 +28,6 @@
 //
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("1.5.12")]
+[assembly: AssemblyVersion("1.5.13")]
 //[assembly: AssemblyFileVersion("1.0.0.0")]
 [assembly: NeutralResourcesLanguage("en-US")]
diff --git a/source/Analyzers/README.md b/source/Analyzers/README.md
@@ -64,7 +64,7 @@ RCS1064|[Avoid usage of for statement to create an infinite loop](../../docs/ana
 RCS1065|[Avoid usage of while statement to create an inifinite loop](../../docs/analyzers/RCS1065.md)|Style|
 RCS1066|[Remove empty finally clause](../../docs/analyzers/RCS1066.md)|Redundancy|x
 RCS1067|[Remove argument list from object creation expression](../../docs/analyzers/RCS1067.md)|Style|
-RCS1068|[Simplify logical not expression](../../docs/analyzers/RCS1068.md)|Simplification|x
+RCS1068|[Simplify logical negation](../../docs/analyzers/RCS1068.md)|Simplification|x
 RCS1069|[Remove unnecessary case label](../../docs/analyzers/RCS1069.md)|Redundancy|x
 RCS1070|[Remove redundant default switch section](../../docs/analyzers/RCS1070.md)|Redundancy|x
 RCS1071|[Remove redundant base constructor call](../../docs/analyzers/RCS1071.md)|Redundancy|x
@@ -194,3 +194,4 @@ RCS1208|[Reduce if nesting](../../docs/analyzers/RCS1208.md)|Style|
 RCS1209|[Reorder type parameter constraints](../../docs/analyzers/RCS1209.md)|Readability|x
 RCS1210|[Return Task\.FromResult instead of returning null](../../docs/analyzers/RCS1210.md)|Usage|x
 RCS1211|[Remove unnecessary else clause](../../docs/analyzers/RCS1211.md)|Redundancy|x
+RCS1212|[Remove redundant assignment](../../docs/analyzers/RCS1212.md)|Redundancy|x
diff --git a/source/CodeFixes/CodeFixesByDiagnosticId.md b/source/CodeFixes/CodeFixesByDiagnosticId.md
@@ -36,8 +36,9 @@ Diagnostic | Code Fixes
 [CS0173](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0173)|RCF0063
 [CS0177](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0177)|RCF0067
 [CS0192](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0192)|RCF0027, RCF0070
-[CS0201](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0201)|RCF0047, RCF0076, RCF0080
+[CS0201](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0201)|RCF0039, RCF0047, RCF0076, RCF0080
 [CS0214](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0214)|RCF0050, RCF0051
+[CS0216](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0216)|RCF0082
 [CS0219](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0219)|RCF0001
 [CS0221](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0221)|RCF0031
 [CS0225](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0225)|RCF0030
@@ -73,6 +74,9 @@ CS0261|RCF0029
 [CS0579](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0579)|RCF0012
 [CS0592](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0592)|RCF0071
 [CS0628](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0628)|RCF0029
+[CS0659](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0659)|RCF0084
+[CS0660](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0660)|RCF0083
+[CS0661](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0661)|RCF0084
 [CS0678](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0678)|RCF0055
 [CS0693](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0693)|RCF0061
 [CS0708](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0708)|RCF0033, RCF0062
@@ -96,6 +100,7 @@ CS0261|RCF0029
 [CS1105](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs1105)|RCF0033, RCF0060
 [CS1106](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs1106)|RCF0033, RCF0060
 [CS1522](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs1522)|RCF0046
+[CS1526](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs1526)|RCF0039
 [CS1527](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs1527)|RCF0029
 [CS1591](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs1591)|RCF0016
 [CS1609](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs1609)|RCF0055

diff --git a/source/CodeFixes/Properties/AssemblyInfo.cs b/source/CodeFixes/Properties/AssemblyInfo.cs
@@ -28,6 +28,6 @@
 //
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("1.5.12")]
+[assembly: AssemblyVersion("1.5.13")]
 //[assembly: AssemblyFileVersion("1.0.0.0")]
 [assembly: NeutralResourcesLanguage("en-US")]
diff --git a/source/CodeFixes/README.md b/source/CodeFixes/README.md
@@ -2,7 +2,7 @@
 
 Id | Title | Fixable Diagnostics | Enabled by Default 
 --- | --- | --- |:---:
-RCF0039|Add argument list|[CS0428](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0428), [CS0023](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0023)|x
+RCF0039|Add argument list|[CS0023](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0023), [CS0428](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0428), [CS0201](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0201), [CS1526](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs1526)|x
 RCF0026|Add body|[CS0501](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0501), [CS0756](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0756)|x
 RCF0009|Add braces to declaration or labeled statement|[CS1023](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs1023)|x
 RCF0002|Add break statement to switch section|[CS0163](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0163), CS8070|x
@@ -27,6 +27,9 @@ RCF0041|Change type of local variable|[CS0123](http://docs.microsoft.com/en-us/d
 RCF0030|Change type of 'params' parameter|[CS0225](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0225)|x
 RCF0066|Combine constraint clauses|[CS0409](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0409)|x
 RCF0003|Create singleton array|[CS0266](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0266)|x
+RCF0082|Define matching operator|[CS0216](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0216)|x
+RCF0083|Define object\.Equals|[CS0660](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0660)|x
+RCF0084|Define object\.GetHashCode|[CS0659](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0659), [CS0661](http://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0661)|x
 RCF0008|Extract declaration from using statement|[CS1674](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs1674)|x
 RCF0038|Fix member access name|[CS1061](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs1061)|x
 RCF0040|Initialize local variable with default value|[CS0165](http://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0165)|x

diff --git a/source/Common/Properties/AssemblyInfo.cs b/source/Common/Properties/AssemblyInfo.cs
@@ -47,6 +47,6 @@
 //
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("1.5.12")]
+[assembly: AssemblyVersion("1.5.13")]
 //[assembly: AssemblyFileVersion("1.0.0.0")]
 [assembly: NeutralResourcesLanguage("en-US")]
diff --git a/source/Core/Properties/AssemblyInfo.cs b/source/Core/Properties/AssemblyInfo.cs
@@ -77,6 +77,6 @@
 //
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("1.5.12")]
+[assembly: AssemblyVersion("1.5.13")]
 //[assembly: AssemblyFileVersion("1.0.0.0")]
 [assembly: NeutralResourcesLanguage("en-US")]
diff --git a/source/DefaultConfigFile.xml b/source/DefaultConfigFile.xml
@@ -190,6 +190,7 @@
       <Refactoring Id="RR0189" IsEnabled="true" /> <!-- ReduceIfNesting -->
       <Refactoring Id="RR0190" IsEnabled="true" /> <!-- ReplaceIfElseWithIfReturn -->
       <Refactoring Id="RR0191" IsEnabled="true" /> <!-- UseCSharp6DictionaryInitializer -->
+      <Refactoring Id="RR0192" IsEnabled="true" /> <!-- ReplaceCommentWithDocumentationComment -->
     </Refactorings>
     <CodeFixes>
       <CodeFix Id="RCF0001" IsEnabled="true" /> <!-- RemoveUnusedVariable (fixes CS0168, CS0219) -->
@@ -228,7 +229,7 @@
       <CodeFix Id="RCF0036" IsEnabled="true" /> <!-- SynchronizeAccessibility (fixes CS0262) -->
       <CodeFix Id="RCF0037" IsEnabled="true" /> <!-- RemoveArgumentList (fixes CS1955) -->
       <CodeFix Id="RCF0038" IsEnabled="true" /> <!-- FixMemberAccessName (fixes CS1061) -->
-      <CodeFix Id="RCF0039" IsEnabled="true" /> <!-- AddArgumentList (fixes CS0428, CS0023) -->
+      <CodeFix Id="RCF0039" IsEnabled="true" /> <!-- AddArgumentList (fixes CS0023, CS0428, CS0201, CS1526) -->
       <CodeFix Id="RCF0040" IsEnabled="true" /> <!-- InitializeLocalVariableWithDefaultValue (fixes CS0165) -->
       <CodeFix Id="RCF0041" IsEnabled="true" /> <!-- ChangeTypeOfLocalVariable (fixes CS0123, CS0407, CS0815) -->
       <CodeFix Id="RCF0042" IsEnabled="true" /> <!-- MakeMemberNonStatic (fixes CS0120) -->
@@ -271,6 +272,9 @@
       <CodeFix Id="RCF0079" IsEnabled="true" /> <!-- ReplaceBreakWithContinue (fixes CS0139) -->
       <CodeFix Id="RCF0080" IsEnabled="true" /> <!-- ChangeMemberTypeAccordingToReturnExpression (fixes CS0029, CS0127, CS0201, CS0266, CS1997) -->
       <CodeFix Id="RCF0081" IsEnabled="true" /> <!-- ReturnDefaultValue (fixes CS0126) -->
+      <CodeFix Id="RCF0082" IsEnabled="true" /> <!-- DefineMatchingOperator (fixes CS0216) -->
+      <CodeFix Id="RCF0083" IsEnabled="true" /> <!-- DefineObjectEquals (fixes CS0660) -->
+      <CodeFix Id="RCF0084" IsEnabled="true" /> <!-- DefineObjectGetHashCode (fixes CS0659, CS0661) -->
     </CodeFixes>
   </Settings>
 </Roslynator>
diff --git a/source/Refactorings/Properties/AssemblyInfo.cs b/source/Refactorings/Properties/AssemblyInfo.cs
@@ -28,6 +28,6 @@
 //
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("1.5.12")]
+[assembly: AssemblyVersion("1.5.13")]
 //[assembly: AssemblyFileVersion("1.0.0.0")]
 [assembly: NeutralResourcesLanguage("en-US")]
diff --git a/source/Refactorings/README.md b/source/Refactorings/README.md
@@ -121,6 +121,7 @@ RR0143|[Replace \(yield\) return statement with if\-else](../../docs/refactoring
 RR0116|[Replace Any with All \(or All with Any\)](../../docs/refactorings/RR0116.md)|x
 RR0117|[Replace as expression with cast expression](../../docs/refactorings/RR0117.md)|x
 RR0118|[Replace cast expression with as expression](../../docs/refactorings/RR0118.md)|x
+RR0192|[Replace comment with documentation comment](../../docs/refactorings/RR0192.md)|x
 RR0119|[Replace conditional expression with expression](../../docs/refactorings/RR0119.md)|x
 RR0121|[Replace constant with field](../../docs/refactorings/RR0121.md)|x
 RR0123|[Replace do statement with while statement](../../docs/refactorings/RR0123.md)|x

diff --git a/source/VisualStudio.Core/Properties/AssemblyInfo.cs b/source/VisualStudio.Core/Properties/AssemblyInfo.cs
@@ -43,5 +43,5 @@
 //
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("1.5.12")]
+[assembly: AssemblyVersion("1.5.13")]
 //[assembly: AssemblyFileVersion("1.0.0.0")]
diff --git a/source/VisualStudio.Refactorings/Properties/AssemblyInfo.cs b/source/VisualStudio.Refactorings/Properties/AssemblyInfo.cs
@@ -31,6 +31,6 @@
 //      Build Number
 //      Revision
 //
-[assembly: AssemblyVersion("1.5.12")]
+[assembly: AssemblyVersion("1.5.13")]
 //[assembly: AssemblyFileVersion("1.0.0.0")]
 [assembly: NeutralResourcesLanguage("en-US")]
diff --git a/source/VisualStudio.Refactorings/source.extension.vsixmanifest b/source/VisualStudio.Refactorings/source.extension.vsixmanifest
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="0117e993-633f-47ea-be07-c0620e5a6788" Version="1.5.12" Language="en-US" Publisher="Josef Pihrt" />
+    <Identity Id="0117e993-633f-47ea-be07-c0620e5a6788" Version="1.5.13" Language="en-US" Publisher="Josef Pihrt" />
     <DisplayName>Roslynator Refactorings 2017</DisplayName>
     <Description xml:space="preserve">A collection of 180+ refactorings for C#, powered by Roslyn.</Description>
     <MoreInfo>http://github.com/JosefPihrt/Roslynator</MoreInfo>

diff --git a/source/VisualStudio/Properties/AssemblyInfo.cs b/source/VisualStudio/Properties/AssemblyInfo.cs
@@ -31,6 +31,6 @@
 //      Build Number
 //      Revision
 //
-[assembly: AssemblyVersion("1.5.12")]
+[assembly: AssemblyVersion("1.5.13")]
 //[assembly: AssemblyFileVersion("1.0.0.0")]
 [assembly: NeutralResourcesLanguage("en-US")]
diff --git a/source/VisualStudio/source.extension.vsixmanifest b/source/VisualStudio/source.extension.vsixmanifest
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="9289a8ab-1bb6-496b-9992-9f7ea27f66a8" Version="1.5.12" Language="en-US" Publisher="Josef Pihrt"/>
+    <Identity Id="9289a8ab-1bb6-496b-9992-9f7ea27f66a8" Version="1.5.13" Language="en-US" Publisher="Josef Pihrt"/>
     <DisplayName>Roslynator 2017</DisplayName>
     <Description xml:space="preserve">A collection of 190+ analyzers and 180+ refactorings for C#, powered by Roslyn.</Description>
     <MoreInfo>http://github.com/JosefPihrt/Roslynator</MoreInfo>