Enabled extract refactorings in LSP #76718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
JoeRobich
force-pushed
the
dev/jorobich/enable-extract-refactorings
branch
from
5399edf to
b4582d8
Compare
JoeRobich
commented
Jan 11, 2025
| UnifiedPredefinedSuggestedActionCategoryNames.StyleFix => CodeActionKind.QuickFix, | ||
| UnifiedPredefinedSuggestedActionCategoryNames.ErrorFix => CodeActionKind.QuickFix, | ||
| _ => throw ExceptionUtilities.UnexpectedValue(categoryName) | ||
| }; | ||
|
|
||
| private static CodeActionKind GetRefactoringKind(IUnifiedSuggestedAction suggestedAction) |
There was a problem hiding this comment.
Providing the proper type will have VS Code render the actions differently.
| ReferenceOutputAssembly="false" | ||
| Private="false" /> | ||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnit" /> |
There was a problem hiding this comment.
This is added to parse test code markup.
JoeRobich
force-pushed
the
dev/jorobich/enable-extract-refactorings
branch
from
b4582d8 to
51e0c13
Compare
JoeRobich
commented
Jan 11, 2025
src/LanguageServer/Protocol/Handler/CodeActions/CodeActionHelpers.cs
Outdated
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the changes in #76717
Options services are added to the LanguageServer project so that the extract refactorings will run. The options use defaults and do not require user interaction. This is part of the O# parity work and the defaults match those used by O#.
Once inserted, this will resolve dotnet/vscode-csharp#6430