Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not parse URIs during LSP serialization/deserialization #76691

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Do not parse URIs during LSP serialization/deserialization

a6bf829
Select commit
Loading
Failed to load commit list.
Draft

Do not parse URIs during LSP serialization/deserialization #76691

Do not parse URIs during LSP serialization/deserialization
a6bf829
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Jan 10, 2025 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Test Failures (6 tests failed)

🔹 [All failing tests from roslyn-CI]

    ⚠️ 2 failing tests not displayed for this pipeline due to space limitations

    ❌ Microsoft.CodeAnalysis.CSharp.Symbol.UnitTests_Microsoft.CodeAnalysis.CSharp.Syntax.UnitTests_Microsoft.CodeAnalysis.CSharp.Workspaces.UnitTests_Micro..._17.WorkItemExecution [Console] [Details] [Artifacts] [6.85% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]
    This is a helix work item crash with status: BadExit. To investigate look the [Console log] / navigate to [Helix Artifacts]

    Failing Configuration
    ❌ Microsoft.CodeAnalysis.CSharp.Workspaces.UnitTests_Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.UnitTests_Microsoft.CodeAnalysis.Features.UnitT..._132.WorkItemExecution [Console] [Details] [Artifacts] [0.35% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]
    This is a helix work item crash with status: BadExit. To investigate look the [Console log] / navigate to [Helix Artifacts]

    Failing Configuration
    ❌ Microsoft.CodeAnalysis.LanguageServer.UnitTests.LspFileChangeWatcherTests.CreatingDirectoryWatchRequestsDirectoryWatch [Console] [Details] [Artifacts] [0.11% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configurations (2)
    Exception Message
    System.Text.Json.JsonException : No sum type match for Roslyn.LanguageServer.Protocol.SumType`2[System.String,Roslyn.LanguageServer.Protocol.RelativePattern]
    CallStack
       at Roslyn.LanguageServer.Protocol.SumConverter`1.Read(Utf8JsonReader& reader, Type objectType, JsonSerializerOptions options) in /_/src/LanguageServer/Protocol/Protocol/Converters/SumConverter.cs:line 253
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
   at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.JsonCollectionConverter`2.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, TCollection& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
   at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, T& value, JsonSerializerOptions options, ReadStack& state)
   at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.Deserialize(Utf8JsonReader& reader, ReadStack& state)
   at System.Text.Json.JsonSerializer.ReadFromSpan[TValue](ReadOnlySpan`1 utf8Json, JsonTypeInfo`1 jsonTypeInfo, Nullable`1 actualByteCount)
   at System.Text.Json.JsonSerializer.Deserialize[TValue](JsonElement element, JsonSerializerOptions options)
   at Microsoft.CodeAnalysis.LanguageServer.UnitTests.LspFileChangeWatcherTests.GetSingleFileWatcher(DynamicCapabilitiesRpcTarget dynamicCapabilities) in /_/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/LspFileChangeWatcherTests.cs:line 113
   at Microsoft.CodeAnalysis.LanguageServer.UnitTests.LspFileChangeWatcherTests.CreatingDirectoryWatchRequestsDirectoryWatch() in /_/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/LspFileChangeWatcherTests.cs:line 63
   at Microsoft.CodeAnalysis.LanguageServer.UnitTests.LspFileChangeWatcherTests.CreatingDirectoryWatchRequestsDirectoryWatch() in /_/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/LspFileChangeWatcherTests.cs:line 71
--- End of stack trace from previous location ---
    ❌ Microsoft.CodeAnalysis.LanguageServer.UnitTests.LspFileChangeWatcherTests.CreatingFileWatchRequestsFileWatch [Console] [Details] [Artifacts] [0.11% failure rate]
    [ 🚧 Report test infrastructure issue] [ 📄 Report test repository issue]

    Failing Configurations (2)
    Exception Message
    System.Text.Json.JsonException : No sum type match for Roslyn.LanguageServer.Protocol.SumType`2[System.String,Roslyn.LanguageServer.Protocol.RelativePattern]
    CallStack
       at Roslyn.LanguageServer.Protocol.SumConverter`1.Read(Utf8JsonReader& reader, Type objectType, JsonSerializerOptions options) in /_/src/LanguageServer/Protocol/Protocol/Converters/SumConverter.cs:line 253
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
   at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.JsonCollectionConverter`2.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, TCollection& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
   at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, T& value, JsonSerializerOptions options, ReadStack& state)
   at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.Deserialize(Utf8JsonReader& reader, ReadStack& state)
   at System.Text.Json.JsonSerializer.ReadFromSpan[TValue](ReadOnlySpan`1 utf8Json, JsonTypeInfo`1 jsonTypeInfo, Nullable`1 actualByteCount)
   at System.Text.Json.JsonSerializer.Deserialize[TValue](JsonElement element, JsonSerializerOptions options)
   at Microsoft.CodeAnalysis.LanguageServer.UnitTests.LspFileChangeWatcherTests.GetSingleFileWatcher(DynamicCapabilitiesRpcTarget dynamicCapabilities) in /_/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/LspFileChangeWatcherTests.cs:line 113
   at Microsoft.CodeAnalysis.LanguageServer.UnitTests.LspFileChangeWatcherTests.CreatingFileWatchRequestsFileWatch() in /_/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/LspFileChangeWatcherTests.cs:line 94
   at Microsoft.CodeAnalysis.LanguageServer.UnitTests.LspFileChangeWatcherTests.CreatingFileWatchRequestsFileWatch() in /_/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer.UnitTests/LspFileChangeWatcherTests.cs:line 102
--- End of stack trace from previous location ---

Was this helpful? Yes No

View more details on Build Analysis