Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enabling Build Acceleration via a feature flag #9181

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Allow enabling Build Acceleration via a feature flag #9181

merged 1 commit into from
Jul 25, 2023

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Jul 24, 2023 •
edited by ghost
Loading

Contributes to #9106. A change is also needed in VS to define the feature flag.

This change adds code that checks the ManagedProjectSystem.EnableBuildAccelerationByDefault feature flag when a project does not explicitly define the AccelerateBuildsInVisualStudio MSBuild property. This allows users to enable the feature at the IDE level, rather than the project level.

If a project defines the AccelerateBuildsInVisualStudio property, then that value overrides any feature flag value.

Microsoft Reviewers: Open in CodeFlow

@drewnoakes drewnoakes added Tenet-Performance This issue affects the "Performance" tenet. Feature-Up-to-date Build up-to-date check that avoids shelling out to MSBuild unless necessary. Performance-Scenario-Build This issue affects build performance. Feature-Build-Acceleration Build Acceleration can skip calls to MSBuild within Visual Studio labels Jul 24, 2023
@drewnoakes drewnoakes added this to the 17.8 milestone Jul 24, 2023
@drewnoakes drewnoakes mentioned this pull request Jul 24, 2023
Closed
11 tasks
@drewnoakes
Allow enabling Build Acceleration via a feature flag
fe6b1ad 
This change adds code that checks the `ManagedProjectSystem.EnableBuildAccelerationByDefault` feature flag when a project does not explicitly define the `AccelerateBuildsInVisualStudio` MSBuild property. This allows users to enable the feature at the IDE level, rather than the project level.

If a project defines the `AccelerateBuildsInVisualStudio` property, then that value overrides any feature flag value.
@drewnoakes drewnoakes force-pushed the build-acceleration-by-default branch from 7922d93 to fe6b1ad Compare July 24, 2023 03:48
@drewnoakes
Copy link
Member Author

drewnoakes commented Jul 24, 2023 •
edited
Loading

A change is also needed in VS to define the feature flag.

The VS feature flag is added in https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/486390.

This PR can be merged before the VS PR, as an unknown feature flag will default to false, which preserves the current behaviour.

@drewnoakes drewnoakes marked this pull request as ready for review July 24, 2023 04:52
@drewnoakes drewnoakes requested a review from a team as a code owner July 24, 2023 04:52
@drewnoakes drewnoakes merged commit fd8d5a6 into dotnet:main Jul 25, 2023
5 checks passed
@drewnoakes drewnoakes deleted the build-acceleration-by-default branch July 25, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileymck haileymck haileymck approved these changes

Assignees
No one assigned
Labels
Feature-Build-Acceleration Build Acceleration can skip calls to MSBuild within Visual Studio Feature-Up-to-date Build up-to-date check that avoids shelling out to MSBuild unless necessary. Performance-Scenario-Build This issue affects build performance. Tenet-Performance This issue affects the "Performance" tenet.
Projects
None yet
Milestone
17.8
Development

Successfully merging this pull request may close these issues.
2 participants
@drewnoakes @haileymck