Add optional Methods w/ CancellationToken to IStorage #9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Eckhardt
commented
Jan 8, 2025
| @@ -17,7 +17,7 @@ public class CosmosGrainStorageOptions : CosmosOptions | |||
| public int InitStage { get; set; } = DEFAULT_INIT_STAGE; | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets a value indicating whether state should be deleted when <see cref="IStorage.ClearStateAsync"/> is called. | |||
| /// Gets or sets a value indicating whether state should be deleted when <see cref="IStorage.ClearStateAsync()"/> is called. | |||
There was a problem hiding this comment.
Without specifying an overload we get a CS0419 (Ambiguous reference), I could just suppress the warning...
There was a problem hiding this comment.
If your change here clears up the ambiguity, then it looks good to me.
ReubenBond
reviewed
Jan 8, 2025
| /// <returns> | ||
| /// A <see cref="Task"/> representing the operation. | ||
| /// </returns> | ||
| Task ClearStateAsync(CancellationToken cancellationToken) => Task.CompletedTask; |
There was a problem hiding this comment.
I believe this should call the original ClearStateAsync overload (i.e, without the CT param)
There was a problem hiding this comment.
That makes sense. Pushed that change, Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9248
Microsoft Reviewers: Open in CodeFlow