New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomize CorrelationId generation per host #9213

Merged

benjaminpetit merged 2 commits into dotnet:main from ReubenBond:fix/randomize-correlation-id-per-host

Nov 5, 2024

Member

ReubenBond commented Nov 1, 2024 •

edited by dotnet-policy-service bot

Loading

This PR introduces per-host randomization for message identifiers.
This serves two purposes:

It makes it easier to search diagnostic logs for instances of a message, since the ids are practically unique.
It allows us to use the message id in subsequent messages to a given grain. In particular, to implement cancellation support cheaply (see Support for .NET CancellationTokens #9127 by @koenbeuk)

Microsoft Reviewers: Open in CodeFlow

ReubenBond added 2 commits

November 1, 2024 16:08


          Randomize CorrelationId generation per host

5fc2248


          Add JobAttempt to pipeline artifact

04f5da9

ReubenBond requested a review from benjaminpetit

November 5, 2024 14:46

benjaminpetit approved these changes

View reviewed changes

benjaminpetit merged commit 186e5f8 into dotnet:main

16 checks passed

ReubenBond deleted the fix/randomize-correlation-id-per-host branch

November 5, 2024 16:28

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet