-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispose ClientClusterManifestProvider
when OutsideRuntimeClient
is stopping
#9211
Merged
ReubenBond
merged 7 commits into
dotnet:main
from
ledjon-behluli:fix-block-host-shutdown
Nov 2, 2024
Merged
Dispose ClientClusterManifestProvider
when OutsideRuntimeClient
is stopping
#9211
ReubenBond
merged 7 commits into
dotnet:main
from
ledjon-behluli:fix-block-host-shutdown
Nov 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ReubenBond
reviewed
Oct 30, 2024
ReubenBond
reviewed
Oct 30, 2024
ReubenBond
reviewed
Oct 31, 2024
ReubenBond
reviewed
Oct 31, 2024
ReubenBond
approved these changes
Oct 31, 2024
I think the failure is unrelated to this PR, but I am investigating it |
Fix for the failure: #9212 |
… of OutsideRuntimeClient
… the cancellation has begun
ReubenBond
force-pushed
the
fix-block-host-shutdown
branch
from
November 2, 2024 00:15
ed8b2ac
to
080f4c8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9206
Microsoft Reviewers: Open in CodeFlow