Fix overread bug in Reader Skip #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than the current buffer size, skip will "overread" the buffer, setting the position to a point > the buffer size. This causes the next read to advance the buffer and consume the first byte which the skip should have already consumed but didn't.
ReubenBond
approved these changes
Nov 7, 2023
ReubenBond
reviewed
Nov 7, 2023
ReubenBond
approved these changes
Nov 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in Reader skip. When the skip count + current position is 1 >than the current buffer size, skip will "overread" the buffer, setting the position to a point > the buffer size.
This causes the next read to advance the buffer and consume the first byte which the skip should have already consumed but didn't.
Microsoft Reviewers: Open in CodeFlow