Prevent progress reversal in cluster membership #8673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix/cluster-rewind
branch
2 times, most recently
from
f56f59d to
b0c4493
Compare
ReubenBond
force-pushed
the
fix/cluster-rewind
branch
from
b0c4493 to
fc847e6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing cluster membership updates to local subscribers, we currently have clauses which allow overwriting the cluster membership snapshot with an initial version, but this is not necessary and can introduce bugs, since several of the consumers expect cluster membership to be monotonically versioned.
Microsoft Reviewers: Open in CodeFlow