Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IStorage apis do not accept cancellation tokens #9248

Open
colombod opened this issue Nov 24, 2024 · 2 comments
Open

IStorage apis do not accept cancellation tokens #9248

colombod opened this issue Nov 24, 2024 · 2 comments

Comments

@colombod
Copy link
Member

Orleans.Core.IStorage async apis should require cancellation tokens for consistently

@ReubenBond
Copy link
Member

Agreed. We should add optional interface methods since adding a parameter would be a breaking change.

@Chris-Eckhardt
Copy link
Contributor

I started a draft PR to add the optional methods to IStorage. I'm not sure how far we want to go with this PR, I feel like modifying Grain class to use them could lead to some messy changes. Let me know what you think. I'm happy to go in whatever direction ya'll think is reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants