Respect a path in MSBuildDebugEngine #8080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
reviewed
Oct 21, 2022
There was a problem hiding this comment.
I wanted something like this a while ago, though I don't remember if I mentioned it to anyone, so I'm in favor.
We use Environment.GetEnvironmentVariable("MSBUILDDEBUGPATH") directly in two places for CLR2 compatibility. We should add this fallback in those places as well.
Also, before Path.IsPathRooted, we should make sure there are no invalid path characters. Path.IsPathRooted can throw on net framework (or old .net core) if there are.
|
Not a bad idea but I'm not going to pursue it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been bothering me that we have to specify both
MSBuildDebugEngine=1andMSBUILDDEBUGPATH=s:\ome\path. Can we do it together?