Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for frame disappears when assigning GradientStops to LinearGradientBrush inside this Frame #25851

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ void UpdateBackground()

_backgroundDrawable = new GradientDrawable();
_backgroundDrawable.SetShape(ShapeType.Rectangle);
UpdateCornerRadius();
this.SetBackground(_backgroundDrawable);
}

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue23951.xaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?xml version="1.0" encoding="utf-8" ?>
<ContentPage
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Maui.Controls.Sample.Issues.Issue23951">

<Grid RowDefinitions="Auto, Auto">
<Frame Grid.Row="0"
CornerRadius="10"
HeightRequest="30"
HorizontalOptions="FillAndExpand">
<Frame.Background>
<LinearGradientBrush x:Name="brush"
EndPoint="1,0"
GradientStops="{Binding GradientStops}">
</LinearGradientBrush>
</Frame.Background>
</Frame>
<Button Grid.Row="1"
Text="UpdateGradientStops"
AutomationId ="Button"
Command="{Binding ClickCommand}" />
</Grid>
</ContentPage>
55 changes: 55 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue23951.xaml.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
using System;
using System.ComponentModel;
using System.Windows.Input;
using Microsoft.Maui.Controls.Internals;

namespace Maui.Controls.Sample.Issues
{
[Issue(IssueTracker.Github, 23951, "[Android] Frame disappears when assigning GradientStops to LinearGradientBrush inside this Frame", PlatformAffected.Android)]
public partial class Issue23951: ContentPage
{
public Issue23951()
{
InitializeComponent();
BindingContext = new Issue23951ViewModel();
}

}

public partial class Issue23951ViewModel : INotifyPropertyChanged
{
public event PropertyChangedEventHandler PropertyChanged;
private GradientStopCollection _gradientStops = new GradientStopCollection();
public GradientStopCollection GradientStops
{
get => _gradientStops;
private set
{
_gradientStops = value;
OnPropertyChanged(nameof(GradientStops));
}
}
public void OnPropertyChanged(string propertyName)
{
PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
}
public ICommand ClickCommand { get; private set; }
public Issue23951ViewModel()
{
UpdateGradientStops();
ClickCommand = new Command(Click);
}

private void Click(object obj)
{
UpdateGradientStops();
}

private void UpdateGradientStops()
{
GradientStops = new GradientStopCollection();
GradientStops.Add(new GradientStop(Color.Parse("Red"), 0f));
GradientStops.Add(new GradientStop(Color.Parse("Blue"), 1f));
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#if !MACCATALYST
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

namespace Microsoft.Maui.TestCases.Tests.Issues
{
public class Issue23951 : _IssuesUITest
{
public Issue23951(TestDevice device) : base(device) { }

public override string Issue => "[Android] Frame disappears when assigning GradientStops to LinearGradientBrush inside this Frame";

[Test]
[Category(UITestCategories.Frame)]
public void FrameCornerRadiusShouldnotChange()
{
App.WaitForElement("Button");
App.Tap("Button");
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshots available in the latest build.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz, the snapshot has been added.

}
}
}
#endif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.