-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix for frame disappears when assigning GradientStops to LinearGradientBrush inside this Frame #25851
Draft
Tamilarasan-Paranthaman
wants to merge
2
commits into
dotnet:main
Choose a base branch
from
Tamilarasan-Paranthaman:fix-23951
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+104
−0
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+22.1 KB
.../TestCases.Android.Tests/snapshots/android/FrameCornerRadiusShouldnotChange.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions
24
src/Controls/tests/TestCases.HostApp/Issues/Issue23951.xaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?xml version="1.0" encoding="utf-8" ?> | ||
<ContentPage | ||
xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
x:Class="Maui.Controls.Sample.Issues.Issue23951"> | ||
|
||
<Grid RowDefinitions="Auto, Auto"> | ||
<Frame Grid.Row="0" | ||
CornerRadius="10" | ||
HeightRequest="30" | ||
HorizontalOptions="FillAndExpand"> | ||
<Frame.Background> | ||
<LinearGradientBrush x:Name="brush" | ||
EndPoint="1,0" | ||
GradientStops="{Binding GradientStops}"> | ||
</LinearGradientBrush> | ||
</Frame.Background> | ||
</Frame> | ||
<Button Grid.Row="1" | ||
Text="UpdateGradientStops" | ||
AutomationId ="Button" | ||
Command="{Binding ClickCommand}" /> | ||
</Grid> | ||
</ContentPage> |
55 changes: 55 additions & 0 deletions
55
src/Controls/tests/TestCases.HostApp/Issues/Issue23951.xaml.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
using System; | ||
using System.ComponentModel; | ||
using System.Windows.Input; | ||
using Microsoft.Maui.Controls.Internals; | ||
|
||
namespace Maui.Controls.Sample.Issues | ||
{ | ||
[Issue(IssueTracker.Github, 23951, "[Android] Frame disappears when assigning GradientStops to LinearGradientBrush inside this Frame", PlatformAffected.Android)] | ||
public partial class Issue23951: ContentPage | ||
{ | ||
public Issue23951() | ||
{ | ||
InitializeComponent(); | ||
BindingContext = new Issue23951ViewModel(); | ||
} | ||
|
||
} | ||
|
||
public partial class Issue23951ViewModel : INotifyPropertyChanged | ||
{ | ||
public event PropertyChangedEventHandler PropertyChanged; | ||
private GradientStopCollection _gradientStops = new GradientStopCollection(); | ||
public GradientStopCollection GradientStops | ||
{ | ||
get => _gradientStops; | ||
private set | ||
{ | ||
_gradientStops = value; | ||
OnPropertyChanged(nameof(GradientStops)); | ||
} | ||
} | ||
public void OnPropertyChanged(string propertyName) | ||
{ | ||
PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName)); | ||
} | ||
public ICommand ClickCommand { get; private set; } | ||
public Issue23951ViewModel() | ||
{ | ||
UpdateGradientStops(); | ||
ClickCommand = new Command(Click); | ||
} | ||
|
||
private void Click(object obj) | ||
{ | ||
UpdateGradientStops(); | ||
} | ||
|
||
private void UpdateGradientStops() | ||
{ | ||
GradientStops = new GradientStopCollection(); | ||
GradientStops.Add(new GradientStop(Color.Parse("Red"), 0f)); | ||
GradientStops.Add(new GradientStop(Color.Parse("Blue"), 1f)); | ||
} | ||
} | ||
} |
24 changes: 24 additions & 0 deletions
24
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23951.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#if !MACCATALYST | ||
using NUnit.Framework; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues | ||
{ | ||
public class Issue23951 : _IssuesUITest | ||
{ | ||
public Issue23951(TestDevice device) : base(device) { } | ||
|
||
public override string Issue => "[Android] Frame disappears when assigning GradientStops to LinearGradientBrush inside this Frame"; | ||
|
||
[Test] | ||
[Category(UITestCategories.Frame)] | ||
public void FrameCornerRadiusShouldnotChange() | ||
{ | ||
App.WaitForElement("Button"); | ||
App.Tap("Button"); | ||
VerifyScreenshot(); | ||
} | ||
} | ||
} | ||
#endif |
Binary file added
BIN
+6.84 KB
...ts/TestCases.WinUI.Tests/snapshots/windows/FrameCornerRadiusShouldnotChange.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+48.2 KB
...ls/tests/TestCases.iOS.Tests/snapshots/ios/FrameCornerRadiusShouldnotChange.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshots available in the latest build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz, the snapshot has been added.