-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Enabling ported UITests from Xamarin.UITests to Appium - 9 #25815
base: main
Are you sure you want to change the base?
[Testing] Enabling ported UITests from Xamarin.UITests to Appium - 9 #25815
Conversation
Hey there @anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
App.Tap("Add One"); | ||
|
||
App.WaitForElement("1234"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could include: App.Screenshot("One more element exists");
Is also available in the Appium extension methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz , In this test case, we primarily focused on validating the view presented in the UI. Therefore, we used WaitForElement
to ensure that the view is present. According to our understanding, App.Screenshot
only captures an image and does not perform any validation. If we still need to include screenshot validations, could we use VerifyScreenshot
instead of App.Screenshot
?
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/AddingMultipleItemsListView.cs
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue1439.cs
Show resolved
Hide resolved
@@ -1,4 +1,5 @@ | |||
using NUnit.Framework; | |||
#if TEST_FAILS_ON_CATALYST // Getting OpenQA.Selenium.InvalidSelectorException on Catalyst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On which line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Encountering an OpenQA.Selenium.InvalidSelectorException on line 23 of Catalyst. We also attempted to adjust the time span for the WaitForElement, still getting same issue.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/AddingMultipleItemsListView.cs
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
} | ||
|
||
[Test] | ||
public void AddingMultipleListViewTests3AddTwoElementToList() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of Change
This PR focuses on re-enabling and updating following tests from the Xamarin.UITest framework to be compatible with Appium. The tests, previously commented out, are reviewed, and modified to ensure they are functional with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 9th group of tests enabled.
TestCases