-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Windows SDK projection for testing #25781
base: main
Are you sure you want to change the base?
Update Windows SDK projection for testing #25781
Conversation
Hey there @manodasanW! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSC : error CS1705: Assembly 'Microsoft.Maui' with identity 'Microsoft.Maui, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' uses 'WinRT.Runtime, Version=2.2.0.0, Culture=neutral, PublicKeyToken=99ea127f02d97709' which has a higher version than referenced assembly 'WinRT.Runtime' with identity 'WinRT.Runtime, Version=2.1.0.0, Culture=neutral, PublicKeyToken=99ea127f02d97709' [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\WinUI\Compatibility.ControlGallery.WinUI.csproj]
CSC : error CS1705: Assembly 'Microsoft.Maui.Controls' with identity 'Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' uses 'WinRT.Runtime, Version=2.2.0.0, Culture=neutral, PublicKeyToken=99ea127f02d97709' which has a higher version than referenced assembly 'WinRT.Runtime' with identity 'WinRT.Runtime, Version=2.1.0.0, Culture=neutral, PublicKeyToken=99ea127f02d97709' [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\WinUI\Compatibility.ControlGallery.WinUI.csproj]
9387 Warning(s)
2 Error(s)
@mattleibow you remember anything about getting this working ? |
I took a look at the binlog and it seems the I wonder if this is some ordering issue for when the TargetFramework gets populated and the
|
I took an attempt at trying to address the issue where |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
I believe the current breaks are due to maui/src/MultiTargeting.targets Line 26 in 353f1a3
|
Why were all the props moved to the targets file? |
See this comment. I was basically trying a change to address the issue where TargetFramework wasn't set when Directory.Build.Props got imported for Compatibility.ControlGallery.WinUI causing for those props to be false. It might be we need to continue setting it in the props and then reset it in targets if empty. |
@@ -20,7 +20,7 @@ | |||
</ItemGroup> | |||
|
|||
<PropertyGroup> | |||
<WindowsSdkPackageVersion>10.0.19041.44</WindowsSdkPackageVersion> | |||
<WindowsSdkPackageVersion>10.0.19041.56</WindowsSdkPackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it can t be 10.0.19041.57 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make that them 57 too, it probably was different versions before due to not having the SDK profile changes. But for testing purposes here, 56 or 57 here are fine.
Description of Change
PR for testing latest Windows SDK projection package
Issues Fixed
Fixes #