Fixed Shell Navigating event issue when switching tabs #25749
+116
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 11, 2024
| var r = RendererForViewController(viewController); | ||
| if (r != null) | ||
| if (r is not null && r != SelectedViewController) |
There was a problem hiding this comment.
Could include an UITest?
There was a problem hiding this comment.
I have added the test case. Could you please review it and let me know if you have any concerns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Detail
Mac and iOS: Clicking on an already-selected tab triggered the Navigating event unnecessarily.
Windows: The Navigating event was not triggered when switching tabs.
Root Cause
Mac and iOS: The event was triggered without checking if the tab was already selected.
Windows: There was no code in place to trigger the Navigating event upon tab switches.
Description of Change
Mac and iOS: Modified the code to trigger Navigating only if a new tab is selected.
Windows: Added logic to trigger Navigating when switching to a different tab.
Tested the behaviour in the following platforms
Issues Fixed
Fixes #25599
Screenshots
BeforeFix.mov
AfterFix.mov