Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve partial events and constructors spec wording #9103

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Improve partial events and constructors spec wording #9103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8799562
Improve partial events and constructors spec wording
jjonescz Jan 27, 2025
95abc48
Clarify event accessor attributes
jjonescz Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions proposals/partial-events-and-constructors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ when it specifies the `event_accessor_declarations` or it has the `extern` modif
Otherwise, it is a *defining declaration*.

A partial constructor declaration is said to be a *defining declaration*
when it has the semicolon body and it lacks the `extern` modifier.
when it has a semicolon body and it lacks the `extern` modifier.
Otherwise, it is an *implementing declaration*.

```cs
Expand All @@ -167,7 +167,7 @@ partial class C
Only the defining declaration of a partial member participates in lookup
and is considered at use sites and for emitting the metadata.
(Except for documentation comments as detailed [below](#documentation-comments).)
The implementing declaration signature is used when nullable-analyzing the associated bodies.
The implementing declaration signature is used for nullable analysis of the associated bodies.

A partial event or constructor:
- May only be declared as a member of a partial type.
Expand All @@ -185,9 +185,9 @@ A defining partial constructor declaration cannot have a constructor initializer
### Attributes

The attributes of the resulting event or constructor are the combined attributes of the partial declarations.
The attributes of each of the resulting event's accessor
are the combined attributes of the corresponding partial declaration accessors.
The attributes of each of the resulting constructor's parameter
The attributes of each of the resulting event accessors
are the attributes of the corresponding partial implementing declaration accessor.
The attributes of each of the resulting constructor parameters
are the combined attributes of the corresponding partial declaration parameters.
The combined attributes are concatenated in an unspecified order and duplicates are not removed.

Expand Down