API diff between .NET 8 and .NET 9 #9602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Nov 12, 2024
|
tarekgh
reviewed
Nov 12, 2024
| - public Activity StartActivity(string name, ActivityKind kind, ActivityContext parentContext, IEnumerable<KeyValuePair<string, object?>>? tags = null, IEnumerable<ActivityLink> links = null, DateTimeOffset startTime = default(DateTimeOffset)); | ||
| + public Activity? StartActivity(string name, ActivityKind kind, ActivityContext parentContext, IEnumerable<KeyValuePair<string, object?>>? tags = null, IEnumerable<ActivityLink>? links = null, DateTimeOffset startTime = default(DateTimeOffset)); | ||
| - public Activity StartActivity(string name, ActivityKind kind, string parentId, IEnumerable<KeyValuePair<string, object?>>? tags = null, IEnumerable<ActivityLink> links = null, DateTimeOffset startTime = default(DateTimeOffset)); | ||
| + public Activity? StartActivity(string name, ActivityKind kind, string? parentId, IEnumerable<KeyValuePair<string, object?>>? tags = null, IEnumerable<ActivityLink>? links = null, DateTimeOffset startTime = default(DateTimeOffset)); |
There was a problem hiding this comment.
These APIs were already using nullable types so I think this is not right diff.
tarekgh
reviewed
Nov 12, 2024
| + public Measurement(T value, in TagList tags); | ||
| } | ||
| - public delegate void MeasurementCallback<T>(Instrument instrument, T measurement, ReadOnlySpan<KeyValuePair<string, object?>> tags, object? state); | ||
| + public delegate void MeasurementCallback<T>(Instrument instrument, T measurement, ReadOnlySpan<KeyValuePair<string, object?>> tags, object? state) where T : struct; |
There was a problem hiding this comment.
tarekgh
reviewed
Nov 12, 2024
| - public Histogram<T> CreateHistogram<T>(string name, string unit = null, string description = null) where T : struct; | ||
| + public Histogram<T> CreateHistogram<T>(string name, string unit, string description) where T : struct; | ||
| - public Histogram<T> CreateHistogram<T>(string name, string unit, string description, IEnumerable<KeyValuePair<string, object?>> tags) where T : struct; | ||
| + public Histogram<T> CreateHistogram<T>(string name, string unit, string description, IEnumerable<KeyValuePair<string, object?>>? tags) where T : struct; |
There was a problem hiding this comment.
|
I added some comments, LGTM otherwise:
|
eiriktsarpalis
approved these changes
Nov 13, 2024
tannergooding
approved these changes
Nov 13, 2024
Comment on lines
+194
to
+200
| - IEnumerator<(TElement Element, TPriority Priority)> IEnumerable<(TElement, TPriority)>.GetEnumerator(); | ||
|
|
||
| + IEnumerator<(TElement Element, TPriority Priority)> IEnumerable<(TElement, TPriority)>.GetEnumerator(); | ||
| public struct Enumerator : IDisposable, IEnumerator, IEnumerator<(TElement, TPriority)> { | ||
| - (TElement Element, TPriority Priority) IEnumerator<(TElement, TPriority)>.Current { get; } | ||
|
|
||
| + (TElement Element, TPriority Priority) IEnumerator<(TElement, TPriority)>.Current { get; } |
There was a problem hiding this comment.
nothing seems to have changed here, and note the empty lines not present anywhere else (for some reason which could be related to this zero diff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo area owners:
Libraries area owners:
Known api-diff tool issues:
If yo usee any of these, please provide a GitHub suggestion in this PR to correct it:
{or{}arcade#10981([AsmDiff] For attributes, move the +/- diff symbol to the attribute instead of the affected API arcade#13814)protected internalvisibility should stop showing. AsmDiff: Do not show APIs withprotected internalvisibility arcade#14579