-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate off of Debian 11 #59584
Merged
Merged
Migrate off of Debian 11 #59584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Dec 20, 2024
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Dec 20, 2024
mthalman
approved these changes
Dec 20, 2024
Contributes to #59185 |
wtgodbe
requested changes
Dec 20, 2024
eng/targets/Helix.Common.props
Outdated
@@ -3,7 +3,7 @@ | |||
<PropertyGroup> | |||
<HelixQueueAlmaLinux8>(AlmaLinux.8.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:almalinux-8-helix-amd64</HelixQueueAlmaLinux8> | |||
<HelixQueueAlpine317>(Alpine.317.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.17-helix-amd64</HelixQueueAlpine317> | |||
<HelixQueueDebian11>(Debian.11.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:debian-11-helix-amd64</HelixQueueDebian11> | |||
<HelixQueueDebian11>(Debian.12.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:debian-12-helix-amd64</HelixQueueDebian11> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change the property name to HelixQueueDebian12
& replace all instances of it in the repo
dotnet-policy-service
bot
added
the
pending-ci-rerun
When assigned to a PR indicates that the CI checks should be rerun
label
Dec 30, 2024
wtgodbe
approved these changes
Jan 7, 2025
wtgodbe
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
community-contribution
Indicates that the PR has been added by a community member
pending-ci-rerun
When assigned to a PR indicates that the CI checks should be rerun
tell-mode
Indicates a PR which is being merged during tell-mode
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aspnetcore references a Debian 11 image that is EOL (see dotnet/core#9625):
Branch: release/8.0
aspnetcore/eng/targets/Helix.Common.props
Line 6 in dc3b208
aspnetcore/eng/targets/Helix.Common.props
Line 7 in e76fa91
aspnetcore/eng/targets/Helix.Common.props
Line 46 in e76fa91
aspnetcore/eng/targets/Helix.Common.props
Line 47 in e76fa91
aspnetcore/eng/targets/Helix.targets
Line 21 in e76fa91
aspnetcore/eng/targets/Helix.targets
Line 22 in e76fa91
Update Debian11 -> 12 and Fedora 38 -> 40