Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flutter json_serializable use JsonValue as the json key of Enum #714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whlsxl
Copy link

@whlsxl whlsxl commented May 11, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Related #713

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Screenshots/Sandbox (if appropriate/relevant):

https://stackblitz.com/edit/github-mc3hpg?file=app_models.dart

How Has This Been Tested?

Change the test in https://github.com/whlsxl/graphql-code-generator-community/blob/main/packages/plugins/dart/flutter-freezed/tests/plugin.spec.ts. to verify this pull request.

Test Environment:

  • OS: macOS 14.0
  •   "@graphql-codegen/cli": "5.0.2",
      "@graphql-codegen/introspection": "4.0.3",
      "@graphql-codegen/typescript": "4.0.6",
      "@graphql-codegen/typescript-resolvers": "4.0.6",```
    
  • NodeJS: v21.7.2

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

From json_serializable version 6, Enum json key from JsonKey to JsonValue, this pull request temporarily solve this problem, but requires more systematic modifications.

Copy link

changeset-bot bot commented May 11, 2024

⚠️ No Changeset found

Latest commit: bcde64c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant