-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(block-editor): Fix add links #29880
Draft
nicobytes
wants to merge
22
commits into
main
Choose a base branch
from
29672-block-editor-add-link-doesnt-show-when-below-on-the-editor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 10 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2e9be12
chore(block-editor): fix some unit tests #29672
nicobytes 29738ec
Merge branch 'master' into 29672-block-editor-add-link-doesnt-show-wh…
nicobytes aefc578
Merge branch 'master' into 29672-block-editor-add-link-doesnt-show-wh…
nicobytes b369b65
Merge branch 'master' into 29672-block-editor-add-link-doesnt-show-wh…
nicobytes 4014928
Merge branch 'master' into 29672-block-editor-add-link-doesnt-show-wh…
nicobytes 77232ff
chore(block-editor): sync with master #29672
nicobytes 68ee450
chore(block-editor): fix error #29672
nicobytes 839c234
chore(block-editor): fix error in deps #29672
nicobytes 9cfcabe
chore(block-editor): upgrade deps #29672
nicobytes 54590f1
chore(block-editor): fix unit tests #29672
nicobytes fe786d3
Merge branch 'master' into 29672-block-editor-add-link-doesnt-show-wh…
nicobytes 41912d2
Merge branch 'master' into 29672-block-editor-add-link-doesnt-show-wh…
nicobytes 7240d75
feat(editor-content): remove log #29672
nicobytes 2945a0f
Merge branch 'master' into 29672-block-editor-add-link-doesnt-show-wh…
nicobytes 04263a5
Merge branch 'main' into 29672-block-editor-add-link-doesnt-show-when…
nicobytes 4179eee
Merge branch 'main' into 29672-block-editor-add-link-doesnt-show-when…
nicobytes 2c3db59
chore(edit-content): sync with master #29672
nicobytes 6bf6e70
Merge branch '29672-block-editor-add-link-doesnt-show-when-below-on-t…
nicobytes 583d190
Merge branch 'main' into 29672-block-editor-add-link-doesnt-show-when…
nicobytes 0fc7fd4
Merge branch 'main' into 29672-block-editor-add-link-doesnt-show-when…
nicobytes 147a1cf
Merge branch 'main' into 29672-block-editor-add-link-doesnt-show-when…
nicobytes cb80768
Merge branch 'main' into 29672-block-editor-add-link-doesnt-show-when…
nicobytes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 22 additions & 18 deletions
40
...ibs/block-editor/src/lib/extensions/ai-content-prompt/ai-content-prompt.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,32 @@ | ||
import { HttpClientTestingModule } from '@angular/common/http/testing'; | ||
import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
import { ReactiveFormsModule } from '@angular/forms'; | ||
import { Spectator, createComponentFactory } from '@ngneat/spectator/jest'; | ||
|
||
import { DotAiService } from '@dotcms/data-access'; | ||
import { provideHttpClient } from '@angular/common/http'; | ||
import { provideHttpClientTesting } from '@angular/common/http/testing'; | ||
|
||
import { AIContentPromptComponent } from './ai-content-prompt.component'; | ||
import { ConfirmationService } from 'primeng/api'; | ||
|
||
describe('AIContentPromptComponent', () => { | ||
let component: AIContentPromptComponent; | ||
let fixture: ComponentFixture<AIContentPromptComponent>; | ||
import { DotAiService, DotMessageService } from '@dotcms/data-access'; | ||
|
||
beforeEach(async () => { | ||
await TestBed.configureTestingModule({ | ||
imports: [ReactiveFormsModule, HttpClientTestingModule], | ||
declarations: [AIContentPromptComponent], | ||
providers: [DotAiService] | ||
}).compileComponents(); | ||
import { AIContentPromptComponent } from './ai-content-prompt.component'; | ||
import { AiContentPromptStore } from './store/ai-content-prompt.store'; | ||
|
||
fixture = TestBed.createComponent(AIContentPromptComponent); | ||
component = fixture.componentInstance; | ||
fixture.detectChanges(); | ||
describe('AIContentPromptComponent', () => { | ||
let spectator: Spectator<AIContentPromptComponent>; | ||
const createComponent = createComponentFactory({ | ||
component: AIContentPromptComponent, | ||
providers: [ | ||
AiContentPromptStore, | ||
DotMessageService, | ||
DotAiService, | ||
ConfirmationService, | ||
provideHttpClient(), | ||
provideHttpClientTesting() | ||
] | ||
}); | ||
|
||
beforeEach(() => (spectator = createComponent())); | ||
|
||
it('should create', () => { | ||
expect(component).toBeTruthy(); | ||
expect(spectator.component).toBeTruthy(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 7 additions & 15 deletions
22
core-web/libs/block-editor/src/lib/extensions/asset-form/asset-form.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,14 @@ | ||
import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
import { createComponentFactory, Spectator } from '@ngneat/spectator/jest'; | ||
|
||
import { ImageTabviewFormComponent } from './image-tabview-form.component'; | ||
import { AssetFormComponent } from './asset-form.component'; | ||
|
||
describe('ImageTabviewFormComponent', () => { | ||
let component: ImageTabviewFormComponent; | ||
let fixture: ComponentFixture<ImageTabviewFormComponent>; | ||
describe('AssetFormComponent', () => { | ||
let spectator: Spectator<AssetFormComponent>; | ||
const createComponent = createComponentFactory(AssetFormComponent); | ||
|
||
beforeEach(async () => { | ||
await TestBed.configureTestingModule({ | ||
declarations: [ImageTabviewFormComponent] | ||
}).compileComponents(); | ||
|
||
fixture = TestBed.createComponent(ImageTabviewFormComponent); | ||
component = fixture.componentInstance; | ||
fixture.detectChanges(); | ||
}); | ||
beforeEach(() => (spectator = createComponent())); | ||
|
||
it('should create', () => { | ||
expect(component).toBeTruthy(); | ||
expect(spectator.component).toBeTruthy(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 8 additions & 13 deletions
21
...ensions/asset-uploader/components/upload-placeholder/upload-placeholder.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,17 @@ | ||
import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
import { Spectator, createComponentFactory } from '@ngneat/spectator/jest'; | ||
|
||
import { UploadPlaceholderComponent } from './upload-placeholder.component'; | ||
|
||
describe('UploadPlaceholderComponent', () => { | ||
let component: UploadPlaceholderComponent; | ||
let fixture: ComponentFixture<UploadPlaceholderComponent>; | ||
|
||
beforeEach(async () => { | ||
await TestBed.configureTestingModule({ | ||
declarations: [UploadPlaceholderComponent] | ||
}).compileComponents(); | ||
|
||
fixture = TestBed.createComponent(UploadPlaceholderComponent); | ||
component = fixture.componentInstance; | ||
fixture.detectChanges(); | ||
let spectator: Spectator<UploadPlaceholderComponent>; | ||
const createComponent = createComponentFactory({ | ||
component: UploadPlaceholderComponent, | ||
providers: [] | ||
}); | ||
|
||
beforeEach(() => (spectator = createComponent())); | ||
|
||
it('should create', () => { | ||
expect(component).toBeTruthy(); | ||
expect(spectator.component).toBeTruthy(); | ||
}); | ||
}); |
2 changes: 1 addition & 1 deletion
2
core-web/libs/block-editor/src/lib/extensions/bubble-form/bubble-form.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 0 additions & 25 deletions
25
.../libs/block-editor/src/lib/extensions/bubble-link-form/bubble-link-form.component.spec.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove