Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move various things into proper places #104

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

andrewbird
Copy link
Member

I found this tidy up that had been hanging around here since last June, so I rebased and made a PR.

@stsp
Copy link
Member

stsp commented Jan 17, 2025

I think this CI currently fails.
So will have to wait.

@stsp
Copy link
Member

stsp commented Jan 17, 2025

By the way, copilot says there is
a kvm on github runners, just permissions
are not set up. Is this true?

@andrewbird
Copy link
Member Author

Yes, we enable it for some dosemu testing, but not fdpp and others.

@stsp stsp closed this Jan 17, 2025
@stsp stsp reopened this Jan 17, 2025
@stsp stsp merged commit 8082524 into dosemu2:master Jan 17, 2025
1 of 2 checks passed
@stsp
Copy link
Member

stsp commented Jan 17, 2025

Thanks!

@andrewbird
Copy link
Member Author

Note: Although the dosemu spat out this message, I don't think it could have exited with an error code as the test still passed.

ERROR: KVM: error opening /dev/kvm: Permission denied
ERROR: libao: unable to open output device
ERROR: Unable to open console or check with X to evaluate the keyboard map.
Please specify your keyboard map explicitly via the $_layout option. Defaulting to US.
Landlock ABI 3 but LANDLOCK_ACCESS_FS_REFER not defined
ERROR: landlock_init() failed
ERROR: kbd: EOF from stdin
ERROR: unknown window sizes li=0  co=0, setting to 80x25

@andrewbird andrewbird deleted the ci-100 branch January 17, 2025 18:44
@stsp
Copy link
Member

stsp commented Jan 17, 2025

Yes, these are not fatal.
I just clicked "Explain failure" button
and copilot said I can enable KVM.
The real problem was that
LANDLOCK_ACCESS_FS_REFER not defined,
but this wasn't logged in the prev versions.
I just added such logging together with the
related fix, as I suspected that could be the
culprit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants