Mock calls to plantuml to reduce CI fragility platforms #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #669 +/- ##
========================================
Coverage 96.24% 96.24%
========================================
Files 41 41
Lines 5220 5220
Branches 1226 1226
========================================
Hits 5024 5024
Misses 124 124
Partials 72 72 ☔ View full report in Codecov by Sentry. |
|
Fixes #667 |
robtaylor
force-pushed
the
fix-codecov-logic
branch
from
4bf299a
to
4add3ff
Compare
robtaylor
force-pushed
the
fix-codecov-logic
branch
from
4add3ff
to
3a0e4c8
Compare
robtaylor
changed the title
|
Merged with #670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #667, calls to and external server for rendering PlantUML introduced fragility to the CI. On the first attempt to fix this issue by including a local copy of PlantUML, it also became clear that it was very hard to get PlantUML to produce exactly duplicate output over different platforms.
This makes the test faster and more robust by simply mocking out the plantuml-markdown execution.