Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove inactive items #619

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Robin-St
Copy link

This is to close #396.

The find_item methods are extended with the argument only_active that defaults to true to keep the old behaviour intact. The various delete functions calls find_item with only_active=False to find any inactive items and be able to delete them.

Test cases are added with copies of the various test cases to remove an item but to try remove req5 that is inactive. Some test files used the test cases in the tutorial folder, as I could not find an inactive req there I added tut26 as an inactive case in that folder.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f34c454) 95.50% compared to head (987a839) 95.35%.

Files Patch % Lines
doorstop/core/tree.py 42.85% 4 Missing ⚠️
doorstop/core/document.py 75.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #619      +/-   ##
===========================================
- Coverage    95.50%   95.35%   -0.16%     
===========================================
  Files           41       41              
  Lines         5053     5059       +6     
  Branches      1184     1187       +3     
===========================================
- Hits          4826     4824       -2     
- Misses         143      150       +7     
- Partials        84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doorstop remove does not remove inactive requirements
2 participants