QF1013: detect strings that could be rewritten with a string literal

[ccoVeille]

fix #1566

[ccoVeille]

Here is a PR that implements the conversion of string to string literal as discussed in

• quickfix QF1013: detect quoted string escaping quote, while backticks could be used #1566

The code adapt what is done in https://github.com/dominikh/go-tools/blob/master/simple/s1007/s1007.go and https://github.com/dominikh/go-tools/blob/master/stylecheck%2Fst1018%2Fst1018.go

[ccoVeille]

The current code is working.

I'm asking for a code review, but also some advice about this code. because it will somehow conflict with what is done in

https://github.com/dominikh/go-tools/blob/master/simple/s1007/s1007.go

as s1007 and q1013 may report twice the error

what would be the best thing to do ?

Thanks

[dominikh]

as s1007 and q1013 may report twice the error

That's probably not much of a problem, especially because QF checks are only used in gopls, not the staticcheck CLI tool, so at worst we'll get two suggestions that fix the same problem. If gopls cares, they can filter the results.

I'll get to review this PR eventually, but it might take a while, as my backlog is fairly long at the moment.

[ccoVeille]

Noted, thanks

[ccoVeille]

@Antonboom

I saw your comment here

Maybe you could review quickly.

I'm curious about your point of view about the fact it should be only a quickfix (not not reported via staticcheck, so not reported by golangci-lint)