Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] Change some tests to use t.TempDir instead of os.TempDir so that their temporary files get cleaned up. #8792

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[no-release-notes] Change some tests to use t.TempDir instead of os.TempDir so that their temporary files get cleaned up. #8792

wants to merge 3 commits into from

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Jan 25, 2025

No description provided.

@reltuk
[no-release-notes] Change some tests to use t.TempDir instead of os.T…
41fe1ac 
…empDir so that their temporary files get cleaned up.
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
41fe1ac ok 5937457
version total_tests
41fe1ac 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
742f276 ok 5937457
version total_tests
742f276 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
be448ee ok 5937457
version total_tests
be448ee 5937457
correctness_percentage
100.0

max-hoffman
max-hoffman approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reltuk @coffeegoddd @max-hoffman