Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] /{.github,go}: update protoc in protobufs #8775

Merged
merged 2 commits into from
Jan 22, 2025
Merged

[no-release-notes] /{.github,go}: update protoc in protobufs #8775

merged 2 commits into from
Jan 22, 2025

Conversation

coffeegoddd
Copy link
Contributor

No description provided.

@coffeegoddd coffeegoddd requested a review from reltuk January 22, 2025 01:11
reltuk
reltuk approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4656df6 ok 5937457
version total_tests
4656df6 5937457
correctness_percentage
100.0

@fulghum fulghum merged commit aa3b51a into main Jan 22, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coffeegoddd @reltuk @fulghum