Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Добавляет бейджик за упоминание #1309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Добавляет бейджик за упоминание #1309

wants to merge 2 commits into from

Conversation

furtivite
Copy link
Member

Для вручения добавьте в бейджи:

  • mentioned

Выглядит так:

Дефолт По ховеру
Снимок экрана 2024-09-24 в 19 19 53 Снимок экрана 2024-09-24 в 19 20 34

@furtivite furtivite requested a review from a team September 24, 2024 17:23
@furtivite furtivite self-assigned this Sep 24, 2024
@furtivite furtivite added улучшение Доработка существующего кухня Работа и устройство репозитория labels Sep 24, 2024
solarrust
solarrust approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@solarrust solarrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кайф! Давно пора было!
@igsekor глянь, пожалуйста, чтобы настройки бэджика были правильные

igsekor
igsekor requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@igsekor igsekor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот так должно заработать корректно

src/libs/badge-constructor/badge-constructor.js Outdated Show resolved Hide resolved
src/libs/badge-constructor/collection.json Outdated Show resolved Hide resolved
src/libs/badge-constructor/collection.json Outdated Show resolved Hide resolved
src/libs/badge-constructor/collection.json Outdated Show resolved Hide resolved
@furtivite @igsekor
Apply suggestions from code review
553a12f 
Co-authored-by: Igor Korovchenko <[email protected]>
@github-actions GitHub Actions
Copy link

Превью контента из 553a12f опубликовано.

@skorobaeus
Copy link
Member

skorobaeus commented Oct 8, 2024 •
edited
Loading

А есть смежный ПР, который эти бэджики бы раздавал участникам?

@furtivite
Copy link
Member Author

А есть смежный ПР, который эти бэджики бы раздавал участникам?

Пока нет. Вначале делаем бейджи, потом раздаём)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skorobaeus skorobaeus skorobaeus approved these changes

@TatianaFokina TatianaFokina TatianaFokina approved these changes

@solarrust solarrust solarrust approved these changes

@HellSquirrel HellSquirrel Awaiting requested review from HellSquirrel HellSquirrel is a code owner

@igsekor igsekor Awaiting requested review from igsekor igsekor is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@furtivite furtivite

Labels
кухня Работа и устройство репозитория улучшение Доработка существующего
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@furtivite @skorobaeus @solarrust @igsekor @TatianaFokina