-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(torii): fetch and process erc721 metadata and image #2544
base: spr/main/bc10539f
Are you sure you want to change the base?
Conversation
6b70cd8
to
48c880f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spr/main/bc10539f #2544 +/- ##
=====================================================
- Coverage 69.19% 68.71% -0.48%
=====================================================
Files 402 403 +1
Lines 51039 51509 +470
=====================================================
+ Hits 35314 35394 +80
- Misses 15725 16115 +390 ☔ View full report in Codecov by Sentry. |
2b703a2
to
624919a
Compare
commit-id:274aaa3a
79572d8
to
ff46557
Compare
624919a
to
5c702b8
Compare
ongoing_futures: JoinSet<Result<RegisterErc721TokenMetadata>>, | ||
deferred_query_messages: Vec<QueryMessage>, | ||
provider: Arc<P>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add comments to mention why they are added?
// Queries should use `transaction` instead of `pool` | ||
// This `pool` is only used to create a new `transaction` | ||
pool: Pool<Sqlite>, | ||
transaction: Transaction<'c, Sqlite>, | ||
publish_queue: Vec<BrokerMessage>, | ||
artifacts_path: Utf8PathBuf, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here comment for it's usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move all the token logic in a new module (maybe executor becomes a folder instead of a single file module)?
This will make the implementation clearer and the impact on the executor.
Stack:
Connection
abstraction to return data for ercBalance and ercTransfer query #2527