feat(torii): fetch and process erc721 metadata and image #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambda-0x
force-pushed
the
spr/main/274aaa3a
branch
4 times, most recently
from
6b70cd8
to
48c880f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spr/main/bc10539f #2544 +/- ##
=====================================================
- Coverage 69.19% 68.71% -0.48%
=====================================================
Files 402 403 +1
Lines 51039 51509 +470
=====================================================
+ Hits 35314 35394 +80
- Misses 15725 16115 +390 ☔ View full report in Codecov by Sentry. |
lambda-0x
force-pushed
the
spr/main/274aaa3a
branch
4 times, most recently
from
2b703a2
to
624919a
Compare
commit-id:274aaa3a
lambda-0x
force-pushed
the
spr/main/bc10539f
branch
from
79572d8
to
ff46557
Compare
lambda-0x
force-pushed
the
spr/main/274aaa3a
branch
from
624919a
to
5c702b8
Compare
glihm
approved these changes
Oct 25, 2024
Comment on lines
+146
to
+148
| ongoing_futures: JoinSet<Result<RegisterErc721TokenMetadata>>, | ||
| deferred_query_messages: Vec<QueryMessage>, | ||
| provider: Arc<P>, |
There was a problem hiding this comment.
Could you add comments to mention why they are added?
| // Queries should use `transaction` instead of `pool` | ||
| // This `pool` is only used to create a new `transaction` | ||
| pool: Pool<Sqlite>, | ||
| transaction: Transaction<'c, Sqlite>, | ||
| publish_queue: Vec<BrokerMessage>, | ||
| artifacts_path: Utf8PathBuf, |
There was a problem hiding this comment.
Same here comment for it's usage.
There was a problem hiding this comment.
Could we move all the token logic in a new module (maybe executor becomes a folder instead of a single file module)?
This will make the implementation clearer and the impact on the executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
Connectionabstraction to return data for ercBalance and ercTransfer query #2527