Fix deck list not reloading after add a new deck

dogo · Apr 20, 2024 · 58516a4 · 58516a4
1 parent e036978
commit 58516a4
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 9 deletions.
diff --git a/SWDestinyTrades/Classes/Base/Database/DatabaseProtocol.swift b/SWDestinyTrades/Classes/Base/Database/DatabaseProtocol.swift
@@ -18,7 +18,7 @@ struct Sorted {
 protocol DatabaseProtocol: AnyObject {
     func create<T: Storable>(_ model: T.Type, completion: @escaping ((T) -> Void)) throws
 
-    func save(object: Storable) throws
+    func save(object: Storable, completion: (() -> Void)?) throws
 
     func update(block: @escaping () -> Void) throws
 

diff --git a/SWDestinyTrades/Classes/CardDetail/Presenter/CardDetailPresenter.swift b/SWDestinyTrades/Classes/CardDetail/Presenter/CardDetailPresenter.swift
@@ -114,7 +114,7 @@ final class CardDetailPresenter: CardDetailPresenterProtocol {
             if let userCollection = results.first {
                 user = userCollection
             } else {
-                try? self?.database?.save(object: user)
+                try? self?.database?.save(object: user, completion: nil)
             }
         }
         return user

diff --git a/SWDestinyTrades/Classes/Database/RealmDatabase+Operations.swift b/SWDestinyTrades/Classes/Database/RealmDatabase+Operations.swift
@@ -22,14 +22,15 @@ extension RealmDatabase {
         }
     }
 
-    func save(object: Storable) throws {
+    func save(object: Storable, completion: (() -> Void)?) throws {
         guard let storable = object as? Object else {
             throw RealmDatabaseError.objectCouldNotBeParsed
         }
 
         try writeSafely { [weak self] in
             self?.realm.add(storable)
         }
+        completion?()
     }
 
     func update(block: @escaping () -> Void) throws {

diff --git a/SWDestinyTrades/Classes/DeckList/Presenter/DeckListPresenter.swift b/SWDestinyTrades/Classes/DeckList/Presenter/DeckListPresenter.swift
@@ -61,7 +61,9 @@ final class DeckListPresenter: DeckListPresenterProtocol {
 extension DeckListPresenter: DeckListProtocol {
 
     func insert(deck: DeckDTO) {
-        try? database?.save(object: deck)
+        try? database?.save(object: deck) { [weak self] in
+            self?.loadDataFromRealm()
+        }
     }
 
     func remove(deck: DeckDTO) {

diff --git a/SWDestinyTrades/Classes/PeopleList/Presenter/PeopleListPresenter.swift b/SWDestinyTrades/Classes/PeopleList/Presenter/PeopleListPresenter.swift
@@ -93,7 +93,7 @@ extension PeopleListPresenter: PeopleListProtocol {
     }
 
     func insert(person: PersonDTO) {
-        try? database?.save(object: person)
+        try? database?.save(object: person, completion: nil)
     }
 }
 

diff --git a/SWDestinyTrades/Classes/UserCollection/Presenter/UserCollectionPresenter.swift b/SWDestinyTrades/Classes/UserCollection/Presenter/UserCollectionPresenter.swift
@@ -68,7 +68,7 @@ final class UserCollectionPresenter: UserCollectionPresenterProtocol {
     }
 
     private func createDatabase(object: UserCollectionDTO) {
-        try? database?.save(object: object)
+        try? database?.save(object: object, completion: nil)
     }
 
     private func getUserCollection() -> UserCollectionDTO {

diff --git a/SWDestinyTradesTests/Screens/AddToDeck/Presenter/AddToDeckPresenterTests.swift b/SWDestinyTradesTests/Screens/AddToDeck/Presenter/AddToDeckPresenterTests.swift
@@ -86,7 +86,7 @@ final class AddToDeckPresenterTests: XCTestCase {
 
     func test_loadDataFromRealm() {
         let userCollection = UserCollectionDTO()
-        try? database?.save(object: userCollection)
+        try? database?.save(object: userCollection, completion: nil)
 
         sut.loadDataFromRealm()
 

diff --git a/SWDestinyTradesTests/Screens/DeckGraph/Datasource/DeckGraphDatasourceTests.swift b/SWDestinyTradesTests/Screens/DeckGraph/Datasource/DeckGraphDatasourceTests.swift
@@ -23,7 +23,7 @@ final class DeckGraphDatasourceTests: XCTestCase {
 
         let deck = DeckDTO.stub()
         let memoryDB = RealmDatabaseHelper.createMemoryDatabase(identifier: #function)
-        try? memoryDB?.save(object: deck)
+        try? memoryDB?.save(object: deck, completion: nil)
 
         sut.updateCollecionViewData(deck: deck)
     }

diff --git a/SWDestinyTradesTests/Screens/DeckGraph/View/DeckGraphCollectionViewTests.swift b/SWDestinyTradesTests/Screens/DeckGraph/View/DeckGraphCollectionViewTests.swift
@@ -29,7 +29,7 @@ final class DeckGraphCollectionViewTests: XCSnapshotableTestCase {
     func test_validLayout() {
         let deck = DeckDTO.stub()
         let memoryDB = RealmDatabaseHelper.createMemoryDatabase(identifier: #function)
-        try? memoryDB?.save(object: deck)
+        try? memoryDB?.save(object: deck, completion: nil)
 
         sut.updateCollecionViewData(deck: deck)
 

diff --git a/SWDestinyTradesTests/Screens/DeckList/Presenter/DeckListPresenterTests.swift b/SWDestinyTradesTests/Screens/DeckList/Presenter/DeckListPresenterTests.swift
@@ -121,6 +121,7 @@ final class DeckListPresenterTests: XCTestCase {
         sut.remove(deck: deck)
 
         XCTAssertNil(findObject(DeckDTO.self, predicate: predicate))
+        XCTAssertEqual(controller.didCallUpdateTableViewData.count, 12)
     }
 
     // MARK: - Test rename