Bump the eslint group with 2 updates

.github/workflows/lint.yml

@@ -33,7 +33,7 @@ jobs:
     - name: Set up Node
       uses: actions/setup-node@v4
       with:
-        node-version: 16.x
+        node-version: 20.x
         cache: yarn
     - name: Install dependencies
       run: |
@@ -53,7 +53,7 @@ jobs:
       - name: Set up Node
         uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version: 20.x
           cache: yarn
       - name: Install dependencies
         run: |

.github/workflows/test.yml

@@ -34,10 +34,10 @@ jobs:
       uses: ruby/setup-ruby@v1
       with:
         bundler-cache: true
-    - name: Use node 16
+    - name: Use node 20
       uses: actions/setup-node@v4
       with:
-        node-version: 16.x
+        node-version: 20.x
         cache: yarn
     - name: Run tests
       env:
@@ -63,7 +63,7 @@ jobs:
     - name: Set up Node
       uses: actions/setup-node@v4
       with:
-        node-version: 16.x
+        node-version: 20.x
         cache: yarn
     - name: Install dependencies
       run: |
@@ -102,10 +102,10 @@ jobs:
       uses: ruby/setup-ruby@v1
       with:
         bundler-cache: true
-    - name: Use node 16
+    - name: Use node 20
       uses: actions/setup-node@v4
       with:
-        node-version: 16.x
+        node-version: 20.x
         cache: yarn
     - name: Setup chromium-chromedriver
       uses: nanasess/setup-chromedriver@master

app/assets/javascripts/course.ts

@@ -293,39 +293,41 @@
     const formCollapse = new bootstrap.Collapse(formCollapseElement, { toggle: false });
 
     function initPanelLogic(): void {
-        document.getElementById("new-course").addEventListener("click", function () {
+        const newCourseButton = document.getElementById("new-course");
+        newCourseButton.addEventListener("click", function () {
             choosePanel.classList.add("hidden");
             formPanel.querySelector(".step-circle").innerHTML = "2";
-            this.closest(".panel")
+            newCourseButton.closest(".panel")
                 .querySelector(".answer")
-                .textContent = this.dataset.answer;
+                .textContent = newCourseButton.dataset.answer;
             fetch("/courses/new.js")
                 .then(req => req.text())
                 .then(resp => eval(resp));
         });
 
-        document.getElementById("copy-course").addEventListener("click", function () {
+        const copyCourseButton = document.getElementById("copy-course");
+        copyCourseButton.addEventListener("click", function () {
             choosePanel.classList.remove("hidden");
             chooseCollapse.show();
             choosePanel.querySelectorAll<HTMLInputElement>(`input[type="radio"]`).forEach(el => {
                 el.checked = false;
             });
             formPanel.classList.add("hidden");
             formPanel.querySelector(".step-circle").innerHTML = "3";
-            this.closest(".panel")
+            copyCourseButton.closest(".panel")
                 .querySelector(".answer")
-                .textContent = this.dataset.answer;
+                .textContent = copyCourseButton.dataset.answer;
         });
     }
 
     function copyCoursesLoaded(): void {
-        document.querySelectorAll("[data-course_id]").forEach(el => {
+        document.querySelectorAll("[data-course_id]").forEach((el: HTMLElement) => {
             el.addEventListener("click", function () {
-                this.querySelector(`input[type="radio"]`).checked = true;
-                this.closest(".panel")
+                (el.querySelector(`input[type="radio"]`) as HTMLInputElement).checked = true;
+                el.closest(".panel")
                     .querySelector(".answer")
-                    .textContent = this.dataset.answer;
-                fetch(`/courses/new.js?copy_options[base_id]=${this.dataset.course_id}`)
+                    .textContent = el.dataset.answer;
+                fetch(`/courses/new.js?copy_options[base_id]=${el.dataset.course_id}`)
                     .then(req => req.text())
                     .then(resp => eval(resp));
             });

app/assets/javascripts/favorite_course_buttons.ts

@@ -6,14 +6,14 @@
 function initFavoriteButtons(doc: Document | HTMLElement = document): void {
     function init(): void {
         doc.querySelectorAll(".favorite-button")
-            .forEach(btn => btn.addEventListener("click", toggleFavorite));
+            .forEach((btn: HTMLElement) => btn.addEventListener("click", () => toggleFavorite(btn)));
     }
 
-    function toggleFavorite(): void {
-        if (this.classList.contains("favorited")) {
-            unfavoriteCourse(this);
+    function toggleFavorite(btn: HTMLElement): void {
+        if (btn.classList.contains("favorited")) {
+            unfavoriteCourse(btn);
         } else {
-            favoriteCourse(this);
+            favoriteCourse(btn);
         }
     }
 
@@ -44,7 +44,7 @@
                 const cloneFavButton = clone.querySelector<HTMLButtonElement>(".favorite-button");
                 cloneFavButton.setAttribute("title", i18n.t("js.unfavorite-course-do"));
                 new bootstrap.Tooltip(cloneFavButton); // is enabled by default
-                cloneFavButton.addEventListener("click", toggleFavorite);
+                cloneFavButton.addEventListener("click", () => toggleFavorite(cloneFavButton));
                 // hack to fix double rendering of content of lit element 'd-series-icon'
                 clone.querySelectorAll("d-series-icon").forEach((el: SeriesIcon) => {
                     el.replaceChildren();

app/assets/javascripts/feedback/actions.ts

@@ -253,7 +253,7 @@ export default class FeedbackActions {
             });
             const values = this.scoreForms.map(f => f.getDataForNested());
             this.update({
-                // eslint-disable-next-line camelcase
+
                 scores_attributes: values
             });
         });
@@ -266,7 +266,7 @@ export default class FeedbackActions {
             });
             const values = this.scoreForms.map(f => f.getDataForNested());
             this.update({
-                // eslint-disable-next-line camelcase
+
                 scores_attributes: values
             });
         });

app/assets/javascripts/feedback/score.ts

@@ -130,7 +130,7 @@ export default class ScoreForm {
         } else {
             return {
                 score: this.input.value,
-                // eslint-disable-next-line camelcase
+
                 score_item_id: this.scoreItemId
             };
         }
@@ -148,15 +148,15 @@ export default class ScoreForm {
         if (this.existing) {
             data = {
                 score: this.input.value,
-                // eslint-disable-next-line camelcase
+
                 expected_score: this.expectedScore.value
             };
         } else {
             data = {
                 score: this.input.value,
-                // eslint-disable-next-line camelcase
+
                 feedback_id: this.parent.options.feedbackId,
-                // eslint-disable-next-line camelcase
+
                 score_item_id: this.scoreItemId
             };
         }
@@ -173,7 +173,7 @@ export default class ScoreForm {
 
     private delete(): void {
         this.doRequest("delete", {
-            // eslint-disable-next-line camelcase
+
             expected_score: this.expectedScore.value
         });
     }

app/assets/javascripts/iframe.ts

@@ -6,7 +6,7 @@
 export function isInIframe(): boolean {
     try {
         return window.self !== window.top;
-    } catch (e) {
+    } catch {
         return true;
     }
 }

app/assets/javascripts/lti.ts

@@ -115,7 +115,7 @@ export function initLtiContentSelection(payloadUrl: string,
             activities: activities,
             series: seriesSelect ? seriesSelect.value : null,
             course: courseSelect.value,
-            // eslint-disable-next-line camelcase
+
             decoded_token: decodedToken
         };
         const responseRaw = await fetch(payloadUrl, {

app/assets/javascripts/question_table.ts

@@ -110,7 +110,7 @@ export class QuestionTable {
             body: JSON.stringify({
                 from: from,
                 question: {
-                    // eslint-disable-next-line camelcase
+
                     question_state: to
                 }
             })

app/assets/javascripts/score_item.ts

@@ -35,9 +35,9 @@ function commonCheckboxInit(
 function initTotalVisibilityCheckboxes(element: HTMLElement): void {
     commonCheckboxInit(element, ".total-visibility-checkbox", checked => {
         return {
-            // eslint-disable-next-line camelcase
+
             evaluation_exercise: {
-                // eslint-disable-next-line camelcase
+
                 visible_score: checked
             }
         };
@@ -47,7 +47,7 @@ function initTotalVisibilityCheckboxes(element: HTMLElement): void {
 function initItemVisibilityCheckboxes(element: HTMLElement): void {
     commonCheckboxInit(element, ".visibility-checkbox", checked => {
         return {
-            // eslint-disable-next-line camelcase
+
             score_item: {
                 visible: checked
             }

app/assets/javascripts/visualisations/cumulative_timeseries.ts

@@ -31,7 +31,7 @@ export class CTimeseriesGraph extends SeriesGraph {
         >;
 
     // data
-    // eslint-disable-next-line camelcase
+
     private data: { ex_id: string, ex_data: { bin: d3.Bin<Date, Date>, cSum: number }[] }[] = [];
     private studentCount: number; // amount of subscribed students
     private maxSum = 0; // largest y-value == max value
@@ -187,7 +187,7 @@ export class CTimeseriesGraph extends SeriesGraph {
     // eslint-disable-next-line camelcase
     protected override processData({ data, exercises, student_count, deadline }: RawData): void {
         this.data = [];
-        // eslint-disable-next-line camelcase
+
         data as { ex_id: number, ex_data: (string | Date)[] }[];
 
         this.parseExercises(exercises, data.map(ex => ex.ex_id));

app/assets/javascripts/visualisations/series_graph.ts

@@ -6,10 +6,8 @@ import { themeState } from "state/Theme";
 import { i18n } from "i18n/i18n";
 
 export type RawData = {
-    // eslint-disable-next-line camelcase
     data: { ex_id: number, ex_data: unknown[] }[],
     exercises: [number, string][],
-    // eslint-disable-next-line camelcase
     student_count: number,
 }
 

app/assets/javascripts/visualisations/violin.ts

@@ -1,4 +1,4 @@
-/* eslint-disable max-len */
+
 // eslint-disable-next-line
 // @ts-nocheck