Fix for initializing Flexie with JS for nested layouts in IE 9 and lower #48
+158
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for existence of object before assigning. Fixes "Uncaught TypeError: Cannot read property 'children' of undefined"
…wer, with tests. The tests only contain relevant flexbox code, and will not flex in browsers where flexbox is natively supported.
…ry through JavaScript only (with no magic CSS parsing).
| @@ -2028,7 +2030,7 @@ var Flexie = (function (win, doc) { | |||
| FLX.version = "1.0.3"; | |||
|
|
|||
| // Load when the DOM is ready | |||
| attachLoadMethod(FLX.init); | |||
| //attachLoadMethod(FLX.init); | |||
There was a problem hiding this comment.
You shouldn't comment that out, as it will prevent Flexie from automatically starting up.
|
Sorry for the confusion, the last commit (40da658) should not be part of this pull request. It comments out the auto init stuff, as we are not using it. Since I had not made a feature branch for the pull request, and it did not get merged, that commit also shows up here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also depends on the fix by @harrylove. The tests contain one example nesting a horizontal layout in a vertical one initialized with CSS and one version set up with JS. The tests only contain flexbox code relevant for Flexie, and will not flex in browsers where flexbox is natively supported.