Remove test logger implementations #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/test-logger-impl
branch
from
1b05b36
to
f7854f3
Compare
derrabus
force-pushed
the
improvement/test-logger-impl
branch
from
f7854f3
to
3dbd326
Compare
|
You're only touching tests here, so why not target 3.8.x? We don't want new tests to use the previous way. |
greg0ire
approved these changes
Aug 26, 2024
Merged
|
Good point, I'm rebasing. |
derrabus
force-pushed
the
improvement/test-logger-impl
branch
from
3dbd326
to
2cd05b3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'd like to leverage the
fig/log-testpackage so we don't have to invent our own mock implementations of the psr/log interfaces.