-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do not merge] add a rightSidebar option #1288
base: develop
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/hkptkpq47 |
@@ -108,7 +108,7 @@ window.$docsify = { | |||
## hideSidebar | |||
|
|||
- Type : `Boolean` | |||
- Default: `true` | |||
- Default: `false` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was wrong
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8e98cb8:
|
* develop: remove `lib` from pull request template as it is gitignored fix: gitignore was ignoring folders in src, so VS Code search results or file fuzzy finder were not working, etc
& > ul | ||
padding-inline-start: 0; | ||
padding-inline-end: 40px; // Chrome's default value. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhildenbiddle I aimed to make all the changes in here non-breaking for the end user.
You may have some opinion on how better to organize this change. Happy to hear if you do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for padding-inline-end: 40px;
thing is to flip it to the other side when the menu is on the left, otherwise it has a default style in Chrome's user-agent style of padding-inline-start: 40px;
.
Maybe padding-inline-start: 40px should be hard-coded for non
right-sidebar` mode, otherwise that one can vary from browser to browser (I don't know if they settled on the same values, haven't checked).
Is the intention to target this for v4, or as a placeholder for v5? If v4, then my questions / concerns outlined in the original issue (#1282) remain:
|
Summary
Allows the sidebar to be on the right side. This is something developers might want (f.e. to match UX patterns on other parts of a site).
When sidebar is on the right the navbar and github corner badge are on the left on desktop. No changes to navbar or github corner on mobile (because on mobile they are hidden when the menu is open).
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.