Skip to content

Commit

Permalink
Merge pull request #69 from crazy-max/pin-macos-vers
Browse files Browse the repository at this point in the history
ci: pin to macos-13
  • Loading branch information
crazy-max authored Apr 25, 2024
2 parents fdc6583 + 99cad45 commit 0f5a011
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 6 deletions.
17 changes: 11 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ jobs:
matrix:
os:
- ubuntu-latest
#- macos-14 # no virt: https://github.com/docker/actions-toolkit/issues/317
- macos-13
- macos-latest
- windows-latest
version:
- pinned
Expand Down Expand Up @@ -61,7 +61,8 @@ jobs:
matrix:
os:
- ubuntu-latest
- macos-latest
#- macos-14 # no virt: https://github.com/docker/actions-toolkit/issues/317
- macos-13
- windows-latest
steps:
-
Expand All @@ -85,7 +86,8 @@ jobs:
matrix:
os:
- ubuntu-latest
- macos-latest
#- macos-14 # no virt: https://github.com/docker/actions-toolkit/issues/317
- macos-13
- windows-latest
steps:
-
Expand Down Expand Up @@ -114,7 +116,8 @@ jobs:
matrix:
os:
- ubuntu-latest
- macos-latest
#- macos-14 # no virt: https://github.com/docker/actions-toolkit/issues/317
- macos-13
- windows-latest
steps:
-
Expand All @@ -136,7 +139,8 @@ jobs:
uses: crazy-max/ghaction-dump-context@v2

lima-start-args:
runs-on: macos-latest
#runs-on: macos-14 # no virt: https://github.com/docker/actions-toolkit/issues/317
runs-on: macos-13
steps:
-
name: Checkout
Expand Down Expand Up @@ -191,8 +195,9 @@ jobs:
fail-fast: false
matrix:
os:
#- macos-14 # no virt: https://github.com/docker/actions-toolkit/issues/317
- macos-13
- macos-latest
- macos-12
steps:
-
name: Checkout
Expand Down
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
GitHub Action to set up (download and install) [Docker CE](https://docs.docker.com/engine/).
Works on Linux, macOS and Windows.

> [!WARNING]
> Does not work on macOS runners with ARM architecture (no nested virtualization):
> * https://github.com/crazy-max/ghaction-setup-docker/pull/53
> * https://github.com/docker/actions-toolkit/issues/317
![Screenshot](.github/setup-docker-action.png)

___
Expand Down

0 comments on commit 0f5a011

Please sign in to comment.