Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the nightly channel #377

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Deprecate the nightly channel #377

merged 1 commit into from
Sep 11, 2023

Conversation

nickjj
Copy link
Contributor

@nickjj nickjj commented Sep 9, 2023

I noticed a discrepancy in the main install script where nightly was marked as unmaintained in a comment but it was also flagged as deprecated in the warning message.

I brought this up with @thaJeztah on Slack and he mentioned he thinks it's ok to officially deprecate the nightly channel.

When I searched this repo for references to nightly I also found a reference to it in the rootless-install script. We didn't discuss that on Slack but I did set things up to deprecate it there as well. I used a similar pattern to what's in the main install script.

Signed-off-by: Nick Janetakis <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nickjj
Copy link
Contributor Author

nickjj commented Sep 11, 2023

Are these pipeline failures on CentOS unrelated to this PR?

@thaJeztah
Copy link
Member

Checking now! I saw CI wasn't triggered yet (awaiting approval) earlier, and I know @neersighted was working on some changes in the deploy pipeline, so let me double check 🤗

Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; there's been no changes to the get.docker.com pipeline for some time in any case.

@neersighted neersighted merged commit e5543d4 into docker:master Sep 11, 2023
9 checks passed
@thaJeztah
Copy link
Member

Looks like it passed the second time, so all is well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants