Skip to content

Commit

Permalink
static: remove unused docker-proxy.exe binary from Windows packages
Browse files Browse the repository at this point in the history
The `docker-proxy.exe` binary was added to the static Windows packages through
commit 09541b5 (which introduced a bug, later
fixed through fc5379f).

It looks like that commit added the `docker-proxy.exe` binary with the
assumption that it's used on Windows (given that its also built in upstream),
but recent discussions revealed that's not the case.

This patch removes binary from the static packages for Windows, because it's
not used.

A quick look at Docker Desktop's build scripts show that it's not included
in those packages, and installation instructions for static binaries on
Windows do not mention this binary, so no further changes should be needed.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
  • Loading branch information
thaJeztah committed Aug 6, 2024
1 parent 2e60f4a commit 1e1bf07
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion static/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ cross-win: cross-win-engine
mkdir -p build/win/amd64/docker
cp $(CLI_DIR)/build/docker-windows-amd64.exe build/win/amd64/docker/docker.exe
cp $(ENGINE_DIR)/bundles/cross/win/dockerd.exe build/win/amd64/docker/dockerd.exe
cp $(ENGINE_DIR)/bundles/cross/win/docker-proxy.exe build/win/amd64/docker/docker-proxy.exe
docker run --rm -v $(CURDIR)/build/win/amd64:/v -w /v alpine sh -c 'apk update&&apk add zip&&zip -r docker-$(GEN_STATIC_VER).zip docker'
$(CHOWN) -R $(shell id -u):$(shell id -g) build

Expand Down

0 comments on commit 1e1bf07

Please sign in to comment.