bake: support setting the context to null in bake #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
bake-null-context
branch
from
e1f381b to
ecfda8f
Compare
jsternberg
force-pushed
the
bake-null-context
branch
2 times, most recently
from
e05f59d to
467c00d
Compare
Setting the context to null in bake will cause the dockerfile to be sent over stdin to the build and will prevent using the default context of "." similar to how this would be used on the command line. When the JSON is printed from bake, it will reproduce the null so subsequent uses can keep the value. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
bake-null-context
branch
from
467c00d to
3989770
Compare
crazy-max
reviewed
Jan 15, 2025
| @@ -610,7 +610,7 @@ func TestHCLContextCwdPrefix(t *testing.T) { | |||
| require.Equal(t, 1, len(m)) | |||
| require.Contains(t, m, "app") | |||
| assert.Equal(t, "test", *m["app"].Dockerfile) | |||
| assert.Equal(t, "foo", *m["app"].Context) | |||
| assert.Equal(t, "cwd://foo", *m["app"].ContextPath()) | |||
There was a problem hiding this comment.
cwd://foo
Was this a bug or is it a behavior change? I think a path.Clean(bi.ContextPath) is missing in this else cond: https://github.com/docker/buildx/pull/2906/files#diff-fbe2fa23203f2ff05f06b6c0731ea90529f90906807483db76a79f6018781465R1422
There was a problem hiding this comment.
It wasn't a bug but it was an artifact of this code that I removed: https://github.com/docker/buildx/pull/2906/files#diff-fbe2fa23203f2ff05f06b6c0731ea90529f90906807483db76a79f6018781465L1285
The function here seemed to be "take target as input and produce build inputs as output" but it was modifying the original target. So the cleaning of cwd://foo is happening but isn't being changed on the original target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the context to null in bake will cause the dockerfile to be sent over stdin to the build and will prevent using the default context of "." similar to how this would be used on the command line.
When the JSON is printed from bake, it will reproduce the null so subsequent uses can keep the value.
Fixes #2611.