Skip to content

Commit

Permalink
Patch cycle - 2024 / Cycle 5 (#59)
Browse files Browse the repository at this point in the history
  • Loading branch information
dallasread authored Dec 12, 2024
1 parent 9065fb1 commit 9eebfc3
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ concurrency:

env:
CARGO_TERM_COLOR: always
MSRV: '1.76'
MSRV: '1.83'

jobs:
check:
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:
matrix:
rust:
- stable
- '1.76'
- '1.83'
steps:
- uses: actions/checkout@v4
- uses: taiki-e/install-action@protoc
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ target/
*.sw[po]
Cargo.lock
.idea
.tool-versions
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
## main

- CHANGED: Deprecated `from` and `to` fields in `EmailForward`
- CHANGED: Drop support for Rust < 1.83
- CHANGED: Add support for Rust 1.83
- CHANGED: `DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature.

## 1.0.0

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ A Rust client for the [DNSimple API v2](https://developer.dnsimple.com/v2/).

## Requirements

- TBD
- Rust: 1.83+

## Usage

Expand Down Expand Up @@ -49,4 +49,4 @@ Contibutions are welcomed. Please open an issue to discuss the changes before op

## License

Copyright (c) 2015-2022 DNSimple Corporation. This is Free Software distributed under the MIT license.
Copyright (c) 2015-2024 DNSimple Corporation. This is Free Software distributed under the MIT license.
9 changes: 9 additions & 0 deletions src/dnsimple/domains_collaborators.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ impl Domains<'_> {
/// `domain_id`: The ID of the domain we want to list the collaborators from
/// `options`: The `RequestOptions`
/// - Pagination
#[deprecated(
note = "`DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature."
)]
pub fn list_collaborators(
&self,
account_id: u64,
Expand Down Expand Up @@ -102,6 +105,9 @@ impl Domains<'_> {
/// `account_id`: The account ID
/// `domain_id`: The ID of the domain we want to list the collaborators of
/// `email`: The email of the collaborator to be added
#[deprecated(
note = "`DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature."
)]
pub fn add_collaborator(
&self,
account_id: u64,
Expand Down Expand Up @@ -138,6 +144,9 @@ impl Domains<'_> {
/// `account_id`: The account ID
/// `domain_id`: The ID of the domain we want to permanently delete
/// `collaborator_id`: The id of the collaborator we want to remove from the domain
#[deprecated(
note = "`DomainCollaborators` have been deprecated and will be removed in the next major version. Please use our Domain Access Control feature."
)]
pub fn remove_collaborator(
&self,
account_id: u64,
Expand Down
4 changes: 4 additions & 0 deletions tests/domains_collaborators_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use crate::common::setup_mock_for;
mod common;

#[test]
#[allow(deprecated)]
fn test_list_collaborators() {
let setup = setup_mock_for(
"/1385/domains/1/collaborators",
Expand Down Expand Up @@ -40,6 +41,7 @@ fn test_list_collaborators() {
}

#[test]
#[allow(deprecated)]
fn test_add_collaborator_success() {
let setup = setup_mock_for(
"/1385/domains/1/collaborators",
Expand Down Expand Up @@ -72,6 +74,7 @@ fn test_add_collaborator_success() {
}

#[test]
#[allow(deprecated)]
fn test_add_collaborator_invite_success() {
let setup = setup_mock_for(
"/1385/domains/1/collaborators",
Expand Down Expand Up @@ -102,6 +105,7 @@ fn test_add_collaborator_invite_success() {
}

#[test]
#[allow(deprecated)]
fn test_remove_collaborator() {
let setup = setup_mock_for(
"/1385/domains/1/collaborators/100",
Expand Down

0 comments on commit 9eebfc3

Please sign in to comment.