fix: support GO111MODULE packages without go files in root #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages don't have any go files in the root directory, for example, those following https://github.com/golang-standards/project-layout In the case of a GO111MODULE package with go.mod in place, we can just use "go list -m" and this will return the package name even without any go files in the project root. I've also updated the script to report all files that fail "go vet" in a single run instead of exiting after finding the first error. This is a fix for issue dnephin#30.
|
It seems better to just use the golangci-lint hook that runs a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages don't have any go files in the root directory, for
example, those following https://github.com/golang-standards/project-layout
In the case of a GO111MODULE package with go.mod in place, we can just
use "go list -m" and this will return the package name even without
any go files in the project root.
I've also updated the script to report all files that fail "go vet" in
a single run instead of exiting after finding the first error.
This is a fix for issue #30.