Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fanzago cmsathome #11513

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fanzago cmsathome #11513

wants to merge 2 commits into from

Conversation

fanzago
Copy link

@fanzago fanzago commented Mar 15, 2023

Fixes #10751

Status

ready

Description

Patch to allow cleanup jobs to succeed in CMS@Home

Is it backward compatible (if not, which system it affects?)

MAYBE

Related PRs

We added a function for the T3_CH_CMSAtHome site to the DeleteMgr.py file in order to delete correctly files using the grinformation reported in the fallback section of the site configuration file

External dependencies / deployment changes

Does it require deployment changes? No. Does it rely on third-party libraries? No.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 tests no longer failing
  • Python3 Pylint check: failed
    • 5 warnings and errors that must be fixed
    • 2 warnings
    • 35 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded
    • 21 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/14106/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

@fanzago Federica, thank you for creating this pull request.

I think we need now need to have someone from the WMCore team to evaluate:

  1. what are the usual parameters for a Cleanup job (from the site-local-config)
  2. how those compare to the fallback setup for T3_CH_CMS_At_Home
  3. how this is used by DeleteMgr
  4. and whether we can implement any generic solution

It might take a little to get back to this, but in case we have a WMAgent upgrade before that happens, we can always apply this patch while a permanent solution is investigated.

@amaltaro
Copy link
Contributor

amaltaro commented May 6, 2024

@fanzago Federica, there has been some changes to the SITECONF setup and it inject conflicts into this pull request.
If this is still relevant, could you update/rebase this PR?

@cmsdmwmbot
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS@Home jobs not being cleaned up
3 participants