Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude GH actions to match with tags starting with JENKINS #11337

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

khurtado
Copy link
Contributor

Fixes #11336

Status

ready

Description

These change exclude github actions to match with tags starting with JENKINS

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

#11318

@khurtado
Copy link
Contributor Author

@amaltaro I tested this briefly on my fork and seemed to work fine.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 25 new failures
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13634/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

I am pretty sure Rucio Int is down, but let us give it another try.

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 25 new failures
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13636/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 25 new failures
    • 2 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13637/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 24 new failures
    • 3 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13638/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

test this please

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: failed
    • 1 new failures
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/13639/artifact/artifacts/PullRequestReport.html

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the prompt fix, Kenyi. Unit test failures are unrelated (unstable tests, actually).

@amaltaro amaltaro merged commit eebc7c1 into dmwm:master Oct 11, 2022
@amaltaro
Copy link
Contributor

@khurtado Kenyi, there is something with GH actions that I don't completely understand.
If you go to the "Actions" tab in this repo, or open the latest action build information, here:
https://github.com/dmwm/WMCore/actions/runs/3321259827

you can see that the build has been marked as failed.

Do you know if this is expected? I'd think that that tag JENKINS_20221025152155 should have not triggered a GH action job, hence never showing up in the Actions tab (especially not as a failure). Could you please investigate this?

@khurtado
Copy link
Contributor Author

@amaltaro Indeed, I. don't know why it was triggered. When I tested these changes in my fork, it excluded any JENKINS* labels successfully. But here is what's different from my testing environment:

Please verify your email address to run GitHub Actions workflows. https://github.com/settings/emails

Meaning, we would need to verify the email address associated with the bot. cmsdmwmbot, by logging in and using https://github.com/settings/emails

With that said, I still don't know why it would be triggered at all. Do you want me to test a different exclusion pattern? It might be possible to:

  • Exclude any push coming from cmsdmwmbot
  • Match to numeric related tags only (e.g.: [0-9].[0-9].[0-9].* or something like that

@amaltaro
Copy link
Contributor

Looking into my own email settings, I don't see anything that could change the behavior of these GH actions. Maybe that message is only recorded because GH actually fails to deilver an email upon action failure(?)

Yes, I think we could explore a different way to filter tags. That will likely be easier than managing to look at the cmsdmwmbot email settings :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter which tags should trigger a PyPi action build
3 participants