Skip to content

Commit

Permalink
Deal with NoRemap error.
Browse files Browse the repository at this point in the history
  • Loading branch information
dmurdoch committed Sep 24, 2024
1 parent ca88a84 commit b820726
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 12 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: rgl2gltf
Type: Package
Title: Read and Write '.gltf' and '.glb' Files
Version: 1.0.4
Version: 1.0.5
Authors@R: c(person("Duncan", "Murdoch", role = c("aut", "cre"),
email = "[email protected]"),
person("Morten S.", "Mikkelsen", role = c("cph")))
Expand All @@ -24,5 +24,5 @@ Suggests:
png,
jpeg
VignetteBuilder: knitr, rmarkdown
RoxygenNote: 7.2.3
RoxygenNote: 7.3.2
Roxygen: list(markdown = TRUE)
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# rgl2gltf 1.0.4
# rgl2gltf 1.0.5

* Support transparency.
* Fix noRemap issue as requested by CRAN.

# rgl2gltf 1.0.3

Expand Down
11 changes: 3 additions & 8 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
1.0.3: Fixed issue found in rlibro additional tests. Now
I'm quite sure all existing CRAN issues have been addressed.
1.0.5:

1.0.2: Minor update in response to request from CRAN.

- Re-ran Roxygen to fix tidy issues.
- Updated URL for glTF web page.
- One very small enhancement.

Small update to add support for transparency and to avoid NoRemap issues
as requested by CRAN.
2 changes: 1 addition & 1 deletion src/calc_tangents.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ int CalcTangents::get_num_vertices_of_face(const SMikkTSpaceContext *context,
} else if (working_mesh->draw_mode == GL_QUADS) {
return 4;
}
error("no vertices with less than 3 and more than 4 supported");
Rf_error("no vertices with less than 3 and more than 4 supported");
}

void CalcTangents::get_position(const SMikkTSpaceContext *context,
Expand Down

0 comments on commit b820726

Please sign in to comment.