New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dgl/runtime): add static_cast to fix clang compilation when using OpenMP #7844

Merged

mfbalin merged 1 commit into dmlc:master from elohmeier:clang-type-fix

Jan 26, 2025

Contributor

elohmeier commented Dec 8, 2024

This fixes a compilation issue on macOS when compiling with OpenMP support:

dgl/include/dgl/runtime/parallel_for.h:88:22: error: no matching function for call to 'min'
      auto end_tid = std::min(end, chunk_size + begin_tid);
                     ^~~~~~~~

Same kind of bug as in #3631.


          fix(dgl/runtime): add static_cast to fix clang compilation when using…

657cf5d

… OpenMP

mfbalin approved these changes

View reviewed changes

Collaborator

mfbalin left a comment

Thank you for the fix.

mfbalin merged commit 51907e0 into dmlc:master

1 check was pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet