-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix connection goes silent #17
base: master
Are you sure you want to change the base?
Conversation
3eb939a
to
3e88a86
Compare
Thanks for working on this! Anything I can help with? |
You are welcome :), this issue was bothering me for a long time. Please take a look, if there is something to be optimized. Kind regards |
@dmikushin there are additional fixes that need to be added, I will update the PR once I finish working on it from my side. |
eb706ae
to
0b00db1
Compare
@dmikushin |
a41a048
to
b225358
Compare
schedule connection retry if it fail, it will quit
added additional notes and fixed "IF ELSE" statement + missing header
Segmentation fault can happen when we attempting to emit signals from within the static method. In other words, from the callback, we need to invoke some non-static method of WebSocket which would emit the needed signal
9c74b2b
to
86f81fe
Compare
Note: a single connection can listen to a maximum of 1024 streams
fix missing pthread_mutex_init & pthread_mutex_destroy.
remove unused lws_extesion & more mutex luck to event-callback
dfc9d36
to
00130a4
Compare
@mussonero Nice progress, should I push this into master? |
Hi @mussonero , I would like to clean up your v2 version and release it under 2.0 tag in this repository. Please let me know, if you disagree. |
Hi, yes sure no problem |
8b945fd
to
9f7c838
Compare
This is a draft for schedule connection retry otherwise quit.
Still need to be optimized