Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maplibre #203

Merged
merged 50 commits into from
Nov 29, 2023
Merged

Maplibre #203

merged 50 commits into from
Nov 29, 2023

Conversation

boeckMt
Copy link
Member

@boeckMt boeckMt commented Sep 5, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the new behavior?

  • New UKIS library @dlr-eoc/map-maplibre for working with maplibre was added. See the README and README.md Todo.
    For implementation details see code for the angular component and some helpers / helpers to create the layers that do not depend on angular. In the feature, we could perhaps move them to @dlr-eoc/utils-maps.

  • An example of how to work with the new maplibre library has been added to the demo-maps.

  • Hint in @dlr-eoc/map-ol to replace private shallowEqual with @dlr-eoc/utilities propsEqual.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Is it part of one/more packages and which?

  • @dlr-eoc/map-maplibre
  • demo-maps

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@mapbox/togeojson 0.16.0 None +6 329 kB tmcw
maplibre-gl 3.3.0 network, filesystem +26 35.1 MB maplibreorg

@boeckMt boeckMt requested a review from indus September 5, 2023 10:40
"__Comment": "The url to the tilejson is not public available so we use the tiles array to skip the request, to make use of the tms service. See https://github.com/openlayers/ol-mapbox-style/blob/v8.2.1/src/util.js#L109",
"url": "",
"tiles": [
"https://a.tiles.geoservice.dlr.de/service/tms/1.0.0/planet_eoc@EPSG%3A900913@pbf/{z}/{x}/{y}.pbf?flipy=true",
Copy link

@indus indus Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vielleicht etwas einfacher:
"abcd".split("").map(s=>https://${s}.tiles.geoservice.dlr.de/service/tms/1.0.0/planet_eoc@EPSG%3A900913@pbf/{z}/{x}/{y}.pbf?flipy=true)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks for that hint!

Copy link
Contributor

@lucas-angermann lucas-angermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I fixed a bug in the tests.

@boeckMt boeckMt merged commit 07eef69 into main Nov 29, 2023
11 checks passed
@boeckMt
Copy link
Member Author

boeckMt commented Nov 29, 2023

If we find things to improve later, we can do that, but for now it should serve as a starting point.

@boeckMt boeckMt deleted the maplibre branch November 29, 2023 15:38
@boeckMt boeckMt restored the maplibre branch November 30, 2023 09:58
@boeckMt boeckMt deleted the maplibre branch November 30, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants