-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maplibre #203
Conversation
…-cesium - use from services-layers
…uce braking changes
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
"__Comment": "The url to the tilejson is not public available so we use the tiles array to skip the request, to make use of the tms service. See https://github.com/openlayers/ol-mapbox-style/blob/v8.2.1/src/util.js#L109", | ||
"url": "", | ||
"tiles": [ | ||
"https://a.tiles.geoservice.dlr.de/service/tms/1.0.0/planet_eoc@EPSG%3A900913@pbf/{z}/{x}/{y}.pbf?flipy=true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vielleicht etwas einfacher:
"abcd".split("").map(s=>
https://${s}.tiles.geoservice.dlr.de/service/tms/1.0.0/planet_eoc@EPSG%3A900913@pbf/{z}/{x}/{y}.pbf?flipy=true)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tanks for that hint!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I fixed a bug in the tests.
If we find things to improve later, we can do that, but for now it should serve as a starting point. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
New UKIS library
@dlr-eoc/map-maplibre
for working with maplibre was added. See the README and README.md Todo.For implementation details see code for the angular component and some helpers / helpers to create the layers that do not depend on angular. In the feature, we could perhaps move them to
@dlr-eoc/utils-maps
.An example of how to work with the new maplibre library has been added to the demo-maps.
Hint in
@dlr-eoc/map-ol
to replaceprivate shallowEqual
with@dlr-eoc/utilities
propsEqual
.Does this PR introduce a breaking change?
Other information
Is it part of one/more packages and which?
@dlr-eoc/map-maplibre