Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix questionable use of floats and re-work all ticking logic #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix questionable use of floats and re-work all ticking logic #21

wants to merge 1 commit into from

Commits on May 8, 2022

  1. Fix questionable use of floats and re-work all ticking logic 

    What's broken?
- Float usage inconsistently used f64 or f32. I changed everything to be f32 since precision isn't really the priority in graphics.
- Float rounding issues were present in several places. For example, the AnimClock never reset the elapsed time leading to a continual loss of precision as the animation progressed.
- Sequences did not handle deltas that crossed animation boundaries. This means that if a one-hour delta was received, only one animation would complete.
- I tried to simplify all the other logic in the process while improving performance.

Signed-off-by: Alex Saveau <[email protected]>
    @SUPERCILEX
    SUPERCILEX committed May 8, 2022
    Configuration menu
    Copy the full SHA
    79255d9 View commit details
    Browse the repository at this point in the history