Trigger observers when TweenCompleted event is sent #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this can get merged soon? Observers make it a lot easier to deal with entity-based events. It looks like that the only failing check is the decreased coverage, but I don't see how that can be improved (false negative?). |
musjj
reviewed
Nov 26, 2024
remove global trigger, as per suggestion Co-authored-by: musjj <[email protected]>
remove entity array as input for trigger_targets, as per suggestion Co-authored-by: musjj <[email protected]>
musjj
reviewed
Dec 2, 2024
removed another global trigger Co-authored-by: musjj <[email protected]>
djeedai
requested changes
Dec 9, 2024
djeedai
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is very simple: trigger observers when the TweenCompleted event gets sent out. I added this right next to event.send() so it will always happen if use "with_completed_event".
However, we may want to add an equivalent to "with_completed_event" so its opt-in, i.e. "with_completed_trigger" and "with_completed_trigger_targets".
For now, this is the easiest solution to get the ball rolling on this.