You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix#167 unless PPSSPP is lying to me. As I suspected it had to do with types and my lack of understanding -- literal values were all doubles instead of intended floats :-) Sorry!
Found this discussion about doubles not working on PSP pspdev/psptoolchain#85 as far as I understand anything with doubles crashed before, and now it's just very slow, because it is done in software
I also reworked the clipping quite a bit (mostly did what was discussed earlier in #148 plus a couple other things), will do another PR shortly
Found this discussion about doubles not working on PSP pspdev/psptoolchain#85 as far as I understand anything with doubles crashed before, and now it's just very slow, because it is done in software
That's wild, good catch.
I've come down with a nasty cold, might check this out later in the week or whenever I feel better.
Found this discussion about doubles not working on PSP pspdev/psptoolchain#85 as far as I understand anything with doubles crashed before, and now it's just very slow, because it is done in software
That's wild, good catch. I've come down with a nasty cold, might check this out later in the week or whenever I feel better.
Sorry for the delayed response, I'm still feeling really bad unfortunately.
Please open this PR for the 1.4.3-candidate - branch since it's a fix for a feature for that release.
You can leave the rework PR as-is =)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #167 unless PPSSPP is lying to me. As I suspected it had to do with types and my lack of understanding -- literal values were all doubles instead of intended floats :-) Sorry!
Found this discussion about doubles not working on PSP pspdev/psptoolchain#85 as far as I understand anything with doubles crashed before, and now it's just very slow, because it is done in software
I also reworked the clipping quite a bit (mostly did what was discussed earlier in #148 plus a couple other things), will do another PR shortly