Printable fx in InstrumentView #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump build tag
Update check and build jobs to include IR-s
Increase pad time to 5 seconds
commit 560dfdf
Author: djdiskmachine <[email protected]>
Date: Fri Oct 18 17:10:45 2024 +0200
Bugfix: Reload sample with fx applied
Applying an effect multiple times didn't load it into working memory
Documentation
commit 1e88439
Author: djdiskmachine <[email protected]>
Date: Thu Oct 17 20:19:33 2024 +0200
Finishing touches
Fixed bug
Crashes if assigning multiple times
Allow wet == 0
On-screen notifications
Won't do:
Build ffmpeg for platforms
Separate commit
Preview with B
Introduces more complexity
commit c79859c
Author: djdiskmachine <[email protected]>
Date: Sun Oct 13 19:12:33 2024 +0200
Breakout and refactor
Swap pad and wet in InstrumentView
Pad increments by at least 5
Assign the new file to the current instrument
Files are now in the correct order
Created class to handle paths, file IO and fx application
Adjust length from loopEnd
Allows adding a fade to end of sample
TODO:
Fix bug:
Need to check if sample is already in collection before running the command
Crashes if assigning multiple times
Allow wet == 0
Preview with B
On-screen notifications
Build ffmpeg for platforms
commit 6915698
Author: djdiskmachine <[email protected]>
Date: Sat Oct 12 13:14:24 2024 +0200
Add selector & padding
Add selector between room, hall, plate, church
Can pad the end with silence
Good for short samples, add a reverb tail
Fades out from original sampe length
Fixes funky name post apply + sort samples
Documentation
TODO:
Breakout and refactor
Add fault handling for no ffmpeg
Build ffmpeg for platforms
commit 0a92478
Author: djdiskmachine <[email protected]>
Date: Fri Oct 11 18:50:10 2024 +0200
Get IR from folder
Gets IR from dedicated folder
Apply and swap file
TODO:
Incomplete SwapWith
Fix funky name post apply
Breakout and refactor
Documentation
commit 2d8729d
Author: djdiskmachine <[email protected]>
Date: Tue Oct 8 21:27:42 2024 +0200
Add dry wet to print fx
Can add ir to wav file
TODO:
Get IR from dedicated ir folder
Breakout and refactor
Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printable fx in InstrumentView